Spec URL: http://www.poolshark.org/src/libpanelappletmm.spec SRPM URL: http://www.poolshark.org/src/libpanelappletmm-2.6.0-1.src.rpm Description: libpanelappletmm is part of the gnomemm project and provides a C++ interface for developing Gnome panel applets.
For 2.6.0-1: * Possibly missing BuildRequires - From build.log: ----------------------------------------------------- Generating code for file enums.h... Generatsh: dot: command not found Problems running dot: exit code=127, command='dot', arguments='"classGtk_1_1EventBox__inherit__graph.dot" -Tpng -o "classGtk_1_1EventBox__inherit__graph.png"' sh: dot: command not found ------------------------------------------------------ (and similar lines follow) Perhaps graphviz is missing from BuildRequires (also graphviz-gd or so MAY be needed for BuildRequries). * %install ------------------------------------------------------ %install make install DESTDIR=$RPM_BUILD_ROOT find $RPM_BUILD_ROOT -type f -name "*.la" -exec rm -f {} ';' mkdir -p $RPM_BUILD_ROOT%{_datadir}/ ------------------------------------------------------ - What is the last line for? * Timestamps - This file installs some text files (such as header files) and keeping timestamps on them is preferable. For recent Makefile, the following method usually works (and also for this package) ------------------------------------------------------ make install DESTDIR=foo INSTALL="%{_install} -p" ------------------------------------------------------ ? %_dist tag - Just a question, however do you dislike to use %_dist tag?
- Yup, I missed the graphviz dependency (and only graphviz) - Stray mkdir line removed (leftover from previous version) - Used the timestamp-preserving INSTALL line - Added the dist tag. I always use them. http://www.poolshark.org/src/libpanelappletmm.spec http://www.poolshark.org/src/libpanelappletmm-2.6.0-2.fc8.src.rpm
Okay. ------------------------------------------------------ This package (libpanelappletmm) is APPROVED by me ------------------------------------------------------
Thanks for the review :-) New Package CVS Request ======================= Package Name: libpanelappletmm Short Description: C++ interface for Gnome panel applets Owners: denis Branches: FC-6 F-7 devel InitialCC: Cvsextras Commits: yes
Please close this bug as NEXTRELEASE when rebuild is done.