Bug 271141 - Vnc doesn't build against current versions of xorg-x11-server
Summary: Vnc doesn't build against current versions of xorg-x11-server
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: vnc
Version: 7
Hardware: All
OS: All
medium
medium
Target Milestone: ---
Assignee: Adam Tkac
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-08-31 12:44 UTC by Lubomir Kundrak
Modified: 2013-04-30 23:37 UTC (History)
2 users (show)

Fixed In Version: 4.1.2-18.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-09-24 15:10:12 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Discussed patch (2.44 KB, text/plain)
2007-09-03 08:32 UTC, Adam Tkac
no flags Details

Description Lubomir Kundrak 2007-08-31 12:44:49 UTC
Description of problem:

These lines from FC-7 vnc.spec bother me:

 56 BuildRequires: xorg-x11-server-source
...
 91 cp -r %{_datadir}/xorg-x11-server-source unix
...
102 pushd unix/xorg-x11-server-source*
103 %patch14 -p3 -b .s390
104 popd

The dependency on xorg-x11-server-source is unversioned and the s390 patch does
not apply against latest xorg-x11-server from both FC-7 and Rawhide.

Comment 1 Adam Tkac 2007-09-03 08:31:33 UTC
Better should be merge that patch to main Xorg branch or drop it. Ajax, what do
you think about this patch?

Comment 2 Adam Tkac 2007-09-03 08:32:46 UTC
Created attachment 185131 [details]
Discussed patch

Comment 3 Adam Jackson 2007-09-20 20:09:36 UTC
I'm not sure I like that patch.  We don't build the Xorg server for s390{,x} at
all right now, so there's really no point trying to build the vnc module for s390.

I'd just not build libvnc.so on s390 for now, but we probably want to fix s390
Xorg builds for real sometime.  (When we do, we won't bother with arch defines
in int10 at all, for example, because s390 doesn't have a PCI bus so there's no
possible way you'd want to build int10 support.)

Comment 4 Adam Tkac 2007-09-24 15:10:12 UTC
After inspection vnc will be built with --disable-xorg option so no patch is
needed. Commited into CVS but release will wait for more serious issue.


Note You need to log in before you can comment on or make changes to this bug.