Description of problem: virsh and virt-manager igbore a given username. Version-Release number of selected component (if applicable): Name : libvirt Version : 0.3.2 Name : virt-manager Version : 0.4.0 How reproducible: Be root and log into a different machine as a different user than root, using an uri: [root@sohost ~]# virsh -c qemu+ssh://fabiand.org:222/system root.org's password: Steps to Reproduce: See example above ... Actual results: virsh ignores the given username (fabiand) Expected results: I get a prompt for the given user e.g: [root@sohost ~]# virsh -c qemu+ssh://fabiand.org:222/system fabiand.org's password: Additional info: Also happens in virt-manager.
Created attachment 205071 [details] Should fix missing recognition of the username when a port is given. The problem might be fixed using this patch. Not tested with different transport protocols.
Looks sensible, but: 1/ a contextual patch (cvs diff -p) is less error prone 2/ usually enhancement are best requested on the mailing-list to get active peer-review W.r.t. 1/ could you send an updated patch, ideally on the mailing list (see http://libvirt.org/bugs.html ), or just attached to this bug, thanks ! Daniel
Created attachment 205441 [details] diff -u patch for adding username handling Actually I thought that this is a bug, because handling a username is part of the remote uri format. For now I'll just post the bug here. Enhacements will go to the mailinglist in future.
Ok, so the problem this patch is fixing is an interaction betweeen the port number & username handling. If you add a port number, then it forgots to look for the username. So this patch looks fine to me.
I think this probably happened as a result of patch fuzzing, causing code to move around. In any case I'm going to commit this to libvirt CVS now.
nice :)