Spec URL: http://allisson.fedorapeople.org/packages/tcputils/tcputils.spec SRPM URL: http://allisson.fedorapeople.org/packages/tcputils/tcputils-0.6.2-1.fc7.src.rpm Description: This is a collection of programs to facilitate TCP programming in shell-scripts. There is also a small library which makes it somewhat easier to create TCP/IP sockets.
Allisson, I would appreciate it if you would review my review request bug 336401 and bug 336421 . (bug 336421 depends on bug 336401.
For 0.6.2-1 * Timestamps - For this package, ------------------------------------------------------ make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" ------------------------------------------------------ works to keep timestamps on man files. For this package it is really preferable because these man files are written more than 10 years ago. - Also you may want to keep timestamps on the tarball in your srpm. You can use "wget -N", for example. ! %attr ------------------------------------------------------- %attr(0644, root, root) %{_mandir}/man1/... ------------------------------------------------------- - While this is not a problem, I prefer to change the permission of files before %install section ends and not to use %attr when possible, i.e. ------------------------------------------------------- %install ....... chmod 0644 $RPM_BUILD_ROOT%{_mandir}/man1/* ------------------------------------------------------- However this is not a blocker.
Update package: Spec URL: http://allisson.fedorapeople.org/packages/tcputils/tcputils.spec SRPM URL: http://allisson.fedorapeople.org/packages/tcputils/tcputils-0.6.2-2.fc7.src.rpm Changes - Keep timestamps on man files
Okay, approved. ------------------------------------------------------------ This package (tcputils) is APPROVED by me ------------------------------------------------------------
New Package CVS Request ======================= Package Name: tcputils Short Description: Utilities for TCP programming in shell-scripts Owners: allisson Branches: FC-6 F-7 InitialCC: Cvsextras Commits: yes
mass branching for F-8 has happened, so I assumed you also wanted a F-8 branch. cvs done.
All done, thank you for review.
Package Change Request ====================== Package Name: tcputils New Branches: EL-4 EL-5
cvs done.