Spec URL: http://stahnma.fedorapeople.org/cdpr.spec SRPM URL: http://stahnma.fedorapeople.org/cdpr-2.2.1-1.src.rpm Description: cdpr is used to decode a Cisco Disovery Protocol (CDP) packet, by default it will report the device ID, the IP Address (of the device), and the port number that the machine is connected to. Optionally it will decode the entire CDP packet.
1) you should use Source URL as Source0: http://downloads.sf.net/sourceforge/%{name}/%{name}-%{version}.tar.gz 2) Not needed README.Win32 and INSTALL as %doc. Remove those files. 3) for fixing dos end of line you can simplify as only sed -i 's/\r//g' COPYING README
Spec URL: http://stahnma.fedorapeople.org/cdpr.spec SRPM URL: http://stahnma.fedorapeople.org/cdpr-2.2.1-2.src.rpm Changes made.
SRPM not working
also, I saw this package does not honor compiler flags. check http://fedoraproject.org/wiki/Packaging/Guidelines#head-8b14098227aebff1cf6188939e9d0877295ac448 Use build section as make CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags} Remember to drop INSTALL from %doc
Sorry about srpm url. Fixed flags and doc. http://stahnma.fedorapeople.org/cdpr-2.2.1-2.fc7.src.rpm http://stahnma.fedorapeople.org/cdpr.spec
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 1e682e7e9c03f9b004c1f97c0ed25431 cdpr-2.2.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honored correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. APPROVED.
New Package CVS Request ======================= Package Name: cdpr Short Description: Cisco Discovery Protocol Analyzer Owners: stahnma Branches: EL-4, EL-5, F-7, F-8 Cvsextras Commits: yes
cvs done.
cdpr-2.2.1-2.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cdpr'
cdpr-2.2.1-2.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cdpr'
Can we CLOSE this review if package is already built and in rawhide?
cdpr-2.2.1-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
cdpr-2.2.1-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.