Bug 3606 - [pump] coding oversight in the new -h code
Summary: [pump] coding oversight in the new -h code
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Raw Hide
Classification: Retired
Component: dhcpcd
Version: 1.0
Hardware: i386
OS: Linux
high
high
Target Milestone: ---
Assignee: Erik Troan
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 1999-06-20 23:20 UTC by Jay Freeman
Modified: 2008-05-01 15:37 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 1999-06-22 19:32:29 UTC


Attachments (Terms of Use)

Description Jay Freeman 1999-06-20 23:20:45 UTC
Spent the last hour manually making each change in a diff
between 0.6.4 (which worked for me) and 0.6.7 (which
doesn't), and noticed something important.  The -h code
uses a char * as a boolean variable to see if it is there
or not, but should be using the first character in the
string.  Changed that, and got it working on MediaOne (my
cable modem provider).  Diff as follows:

diff pump-0.6.7/pump.c pump-mine/pump.c
1171c1171
<                          cmd.u.start.reqHostname ?
---
>                          cmd.u.start.reqHostname[0] ?

Before what would happen is pump would sit there for about
15 seconds before finally stating "Operation failed".

Comment 1 Jay Freeman 1999-06-21 05:28:59 UTC
(and just to beat breed@almaden.ibm.com to the punch...)
The patch at http://www.cse.ucsc.edu/~breed/pump.patch does NOT fix
this :P.

Comment 2 Erik Troan 1999-06-22 19:32:59 UTC
Ugh.

I just committed this to CVS -- would you like to test the new version
for me before we stick it on the errata?

------- Additional Comments From   06/22/99 15:51 -------
Sure, give me an address of some sort to get access to it and I will test it (don't know where the pump development goes on so don't know where to get the CVS version, or do you mean the redhat CVS? well, regardless...).

Comment 3 Jay Freeman 1999-06-22 19:51:59 UTC
Sure, give me an address of some sort to get access to it and I will test it (don't know where the pump development goes on so don't know where to get the CVS version, or do you mean the redhat CVS? well, regardless...).


Note You need to log in before you can comment on or make changes to this bug.