Spec URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts.spec SRPM URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts-0.2.16-0.srpm Description: The WenQuanYi Zen Hei is the first open-source Chinese font for Hei Ti, a sans-serif font style that are widely used for general purpose text formatting, and on-screen display of Chinese characters (such as on Windows Vista and Mac OS). Simple and elegant font outlines and slightly emboldened strokes makes the glyphs present higher contrast and therefore easy to read. The unique style of this font also provide a simple interface for adding grid-fitting information for further fine-tuning of the on-screen performance. WenQuanYi Zen Hei has over 20400 Hanzi glyphs covering 97% of the Unicode CJK Unified Ideographics. This font provides full coverage to the required code points for zh_cn, zh_sg, zh_tw, zh_hk and zh_mo locales. The total vector glyphs in this font is over 35000 including Latin characters, Japanese kanas, hanguls and symbols from many other languages. The only problem so far is that mkfontdir seems did not generate proper fonts.dir file, although the font can be used normally on the system (via fontconfig).
one more thing, the third digit of the upstream version number represents the accummulative compilation number for the software to generate the font outlines (currently the 16th), I copied it to the %{version} field. if it seems to be odd from Fedora's tradition, I can set it to zero.
Thanks for the submission. :) BTW srpm is http://wenq.org/release/zenhei/wqy-zenhei-fonts-0.2.16-0.src.rpm
(In reply to comment #1) > one more thing, the third digit of the upstream version number represents the > accummulative compilation number for the software to generate the font outlines > (currently the 16th), I copied it to the %{version} field. if it seems to be odd > from Fedora's tradition, I can set it to zero. I think that is fine, but since this is a snapshot (pre-release?) the release number should remain below 1 until the final 0.2.16 release or next one. So please start with 0.1 in the release field.
yes, this is a pre-release version. However, it is likely that we will skip 0.2.16 and release the following version if everything goes right. For version number control, I agree that 0.1 is appropriate for release. the spec/srpm were updated: Spec URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts.spec SRPM URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts-0.2.16-0.1.src.rpm
Created attachment 246371 [details] wqy-zenhei-fonts.spec-1.patch Basically looks ok to me. Here are some minor cleanups/fixes and improvements.
Ah one more: better to use %{fontname} in %setup too. :)
thank you. I patched the spec file with your edits, and replaced wqy-zenhei with %{fontname} (in %setup field and in 44-wqy-zenhei.conf file names). the new spec/srpm: Spec URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts.spec SRPM URL: http://wenq.org/release/zenhei/wqy-zenhei-fonts-0.2.16-0.2.src.rpm
Thanks. Here is the review: Good: + rpmlint clean, except waivable wqy-zenhei-fonts.noarch: W: symlink-should-be-relative /etc/X11/fontpath.d/wqy-zenhei-fonts /usr/share/fonts/wqy-zenhei + package is named after upstream wqy-zenhei + meets packaging guidelines + license is GPL2 with font embedding exception + source matches upstream tarball 1b79021d813cc22e1be3a117533d8145 wqy-zenhei-0.2.16-CVS20071031.tar.gz + noarch package builds correctly + buildreq is listed + filelist is correct + good macro usage + content is a free truetype font Needs attention - according to http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837 the release field should be 0.1.20071031cvs to make it clear that it is a snapshot release. I tested the package and it seems to work ok. I note that it seems to override cjkunifonts. Except maybe the release field as noted above, all MUST items are satisfied. Package is APPROVED.
One other thing, I don't know if you want to consider putting the source in the tarball (maybe now or later) rather than just shipping the .ttf file. Do you build it with fontforge?
thank you Jens. The cvs tag was added to the spec file and I will commit the updated packages when the cvs module is ready. You are right, I used fontforge to assemble the generated glyphs into the ttf file. I do have the sfd file of the font, however, the size of the file is 104MB! Indeed, if you load the ttf into fontforge, you can generate almost the same sfd file. So, in that aspect, I think the ttf is good enough to serve as both the font itself and the source.
New Package CVS Request ======================= Package Name: wqy-zenhei-fonts Short Description: WenQuanYi Zen Hei, a Hei Ti style outline Chinese font Owners: fangq, petersen Branches: FC-6, F-7 InitialCC: petersen
New Package CVS Request ======================= Package Name: wqy-zenhei-fonts Short Description: WenQuanYi Zen Hei, a Hei Ti style outline Chinese font Owners: fangq, petersen Branches: FC-6 F-7 F-8 InitialCC: petersen
Resetting review flag: see comment 8.
cvs done.
wqy-zenhei-fonts-0.2.16-0.2.20071031cvs.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.
wqy-zenhei-fonts-0.2.16-0.2.20071031cvs.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.