Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Upload.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-HTTP-Upload-0.9.1-1.fc7.src.rpm Description: This class provides an advanced file uploader system for file uploads made from html forms. Features: * Can handle from one file to multiple files. * Safe file copying from tmp dir. * Easy detecting mechanism of valid upload, missing upload or error. * Gives extensive information about the uploaded file. * Rename uploaded files in different ways: as it is, safe or unique * Validate allowed file extensions * Multiple languages error messages support (es, en, de, fr, it, nl, pt_BR) %changelog * Fri Nov 23 2007 Christopher Stone <chris.stone> 0.9.1-1 - Initial Fedora release
arg, the sample doesn't work... I think it would be cool to patch it : Line 14 : if (!isset($_GET["submit"])) { It's not a issue for the review.
REVIEW: * rpmlint : OK * The package is named according to the Package Naming Guidelines. * The spec file name match the base package * The package follow the PHP Packaging Guidelines * Fedora approved license (LGPL) * License field in the package spec file match the actual license * The spec file is written in American English * The spec file is legible * The sources used to build the package must match the upstream source fd1161202786fcba5272d2715bcda787 HTTP_Upload-0.9.1.tgz * build in mock (F-7, noarch) * All build dependencies are listed in BuildRequires * no locales * no shared library files * package own all directories that it creates * Package don't own files or directories already owned by other packages (HTTP owned by php-pear-HTTP-Request, but no dependencies, so it's ok) * no duplicate files * Permissions on files are set properly * %clean section * package consistently use macros * The package contain code * small documentation * no library * no desktop file * %install, start with rm -rf %{buildroot} * All filenames are valid UTF-8 * scriptlets are sane* * Final Provides ok php-pear(HTTP_Upload) = 0.9.1 php-pear-HTTP-Upload = 0.9.1-1.fc8 * Final Requires see below /usr/bin/pear php-pear(PEAR) Should : see previous comment APPROVED
New Package CVS Request ======================= Package Name: php-pear-HTTP-Upload Short Description: Secure managment of files submitted via HTML Forms Owners: xulchris Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs admin done
Added EL-5 too per request of xulchris.
php-pear-HTTP-Upload-0.9.1-2.fc8 has been submitted as an update for Fedora 8
Package Change Request ====================== Package Name: php-pear-HTTP-Upload New Branches: EL-5 Jens said he added an EL-5 branch, and I got an e-mail from packagedb to that regard, but when I try to do a cvs up -d command, the EL-5 branch is not showing up.
Should be fixed now. Can you check and confirm?
Yep, fixed now, thx :)
php-pear-HTTP-Upload-0.9.1-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
Built successfully on all branches, thanks for the review! :D