Bug 399171 - Review Request: perl-MooseX-AttributeHelpers - Extended Moose attribute interfaces
Review Request: perl-MooseX-AttributeHelpers - Extended Moose attribute inter...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/MooseX-At...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-11-26 02:17 EST by Chris Weyl
Modified: 2013-05-07 11:19 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-11-26 21:08:47 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2007-11-26 02:17:44 EST
SRPM URL: http://fedora.biggerontheinside.net/review/perl-MooseX-AttributeHelpers-0.05-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-MooseX-AttributeHelpers.spec

Description:
While Moose attributes provide you with a way to name your accessors,
readers, writers, clearers and predicates, this library provides commonly
used attribute helper methods for more specific types of data.
Comment 1 Parag AN(पराग) 2007-11-26 05:51:13 EST
something goes wrong at mock build
ERROR: Bad build req: No Package Found for perl(Moose) >= 0.30. Exiting.

Comment 2 Parag AN(पराग) 2007-11-26 06:30:22 EST
oops its already in rawhide. I missed rawhide updates to my local mock repo.
Here comes now Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
c4a9f6cdc106c6bf9a330d7f20c5fdd4  MooseX-AttributeHelpers-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
t/000_load.....................ok
t/001_basic_counter............ok
t/002_basic_array..............ok
t/003_basic_hash...............ok
t/004_basic_number.............ok
t/005_basic_list...............ok
t/006_basic_bag................ok
t/010_array_from_role..........ok                                            
t/011_counter_with_defaults....ok                                            
t/100_collection_with_roles....ok                                            
t/pod..........................ok                                            
t/pod_coverage.................ok                                            
All tests successful.
Files=12, Tests=224, 18 wallclock secs (12.38 cusr +  0.38 csys = 12.76 CPU)

APPROVED.


Comment 3 Chris Weyl 2007-11-26 11:37:42 EST
New Package CVS Request
=======================
Package Name: perl-MooseX-AttributeHelpers
Short Description: Extended Moose attribute interfaces
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig
Comment 4 Kevin Fenzi 2007-11-26 12:55:06 EST
cvs done.
Comment 5 Chris Weyl 2007-11-26 21:08:47 EST
Imported and built for devel; waiting on perl-Moose/Class-MOP updates to hit
F-[78] to build for those.

Thanks for the review! :)
Comment 6 Andrea Veri 2013-05-07 11:01:28 EDT
Package Change Request
======================
Package Name: perl-MooseX-AttributeHelpers
New Branches: el6
Owners: averi psabata
InitialCC: perl-sig
Comment 7 Jon Ciesla 2013-05-07 11:19:12 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.