Spec URL: http://karlik.nonlogic.org/fusion-icon/fusion-icon.spec SRPM URL: http://karlik.nonlogic.org/fusion-icon/fusion-icon-0-0.1.20071126git.fc8.src.rpm Description: The Compiz Fusion Icon is a simple panel applet for starting and controlling Compiz Fusion. Upon launch, it will attempt to start Compiz Fusion automatically. You may need to select a window decorator, if one does not appear.
rpmlint reported fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/data.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/start.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/parser.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/execute.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/environment.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/__init__.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/util.py 0644 fusion-icon-gtk.noarch: W: no-documentation fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/main.py 0644 fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/__init__.py 0644 fusion-icon-qt.noarch: W: no-documentation fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/main.py 0644 fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/__init__.py 0644
I think it might be ignored, because these scripts are only included by "core" and fusion-icon doesn't require chmod +x to work. If it is blocking the approving, I can set +x. "no-documentation" can be ignored because of needing core package.
Being the reviewer here and in my opinion rpmlint errors reported above are safe to ignore.
source is not matching upstream. do you want to keep logs directory that is producing difference or can you remove them?
If it is a problem I can remove .git before taring but in the next release if it is not a problem for reviewing.
no problem for now but take care to remove them from next release please. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM. - rpmlint complains follwing messages on RPMS fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/data.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/start.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/parser.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/execute.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/environment.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/__init__.py 0644 fusion-icon.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/util.py 0644 fusion-icon-gtk.noarch: W: no-documentation fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/main.py 0644 fusion-icon-gtk.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_gtk/__init__.py 0644 fusion-icon-qt.noarch: W: no-documentation fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/main.py 0644 fusion-icon-qt.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/FusionIcon/interface_qt4/__init__.py 0644 + source files match upstream with assumptions that logs will differ dd4c1c967fe4bb1282801e22bb43fa41 fusion-icon-20071126.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists but -gtk and -qt subpackages present. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly. + GUI app. APPROVED.
Thanks for review and approve.
New Package CVS Request ======================= Package Name: fusion-icon Short Description: Compiz Fusion panel applet Owners: karlikt Branches: F-8 InitialCC: Cvsextras Commits: yes
(Please use fedora account names for Owners line...) cvs done.
Built correct for F-8.
Hi Karol, I would like fusion-icon to be included in EPEL6, I have built all the other compiz packages required. https://admin.fedoraproject.org/updates/compizconfig-backend-kconfig4-0.8.4-3.el6,emerald-themes-0.5.2-5.el6,emerald-0.8.2-3.el6,compiz-manager-0.6.0-11.el6,compizconfig-backend-gconf-0.8.2-4.el6,compiz-fusion-extras-0.8.2-6.el6,compiz-fusion-unsupported-0.8.2-2.el6,compizconfig-python-0.8.2-3.el6,ccsm-0.8.2-5.el6,libcompizconfig-0.8.2-9.el6,compiz-fusion-0.8.2-8.el6,compiz-bcop-0.8.2-3.el6 Would you like to build it or grant me permission to do so? Many thanks Leigh
I'll grant perms to you because I don't have RHEL nor CentOS.
Package Change Request ====================== Package Name: fusion-icon New Branches: el6 Owners: karlik leigh123linux
(In reply to comment #12) > I'll grant perms to you because I don't have RHEL nor CentOS. Thank you.
Git done (by process-git-requests).