Bug 400861 - please add a wrapper for gtk_moz_embed_set_path()
Summary: please add a wrapper for gtk_moz_embed_set_path()
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-python2-extras
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Matthew Barnes
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-11-27 12:22 UTC by Martin Stransky
Modified: 2007-12-28 15:02 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-11 15:55:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
a minimal patch (1.19 KB, patch)
2007-11-27 12:22 UTC, Martin Stransky
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
GNOME Bugzilla 503067 0 None None None Never

Description Martin Stransky 2007-11-27 12:22:47 UTC
Hello,

I've just added a minimal patch what exports gtk_moz_embed_set_path() from
gecko-libs.

gtk_moz_embed_set_path() is used for initialization in gecko-libs 1.9 instead of
the recent gtk_moz_embed_set_comp_path(). See
http://fedoraproject.org/wiki/Releases/FeatureXULRunnerAPIChanges and
http://fedoraproject.org/wiki/Releases/FeatureXULRunner

Please check that patch if it's correct, extend it and propagate it to upstream.

Version-Release number of selected component (if applicable):

gnome-python2-extras-2.19.1-12.fc9

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Martin Stransky 2007-11-27 12:22:47 UTC
Created attachment 269691 [details]
a minimal patch

Comment 2 Matthew Barnes 2007-12-11 15:55:45 UTC
Looks okay to me, moving upstream.  Please see [1] for further updates.

Let me know if you need me to patch the Fedora package in the meantime.

[1] http://bugzilla.gnome.org/show_bug.cgi?id=503067

Comment 3 Matthew Barnes 2007-12-15 17:58:19 UTC
Patch was committed upstream but still needs API documentation written for it. 
Feel free to contribute a patch for that to the same upstream bug.

Comment 4 Gian Mario Tagliaretti 2007-12-28 15:02:49 UTC
Mattew the patch cannot be applied as it is, it will break the module with all
previous versions of the browser where the function doesn't exist, I've reopened
upstream.


Note You need to log in before you can comment on or make changes to this bug.