Created attachment 277421 [details] modversions
First pass through the spec and rpmlint: 1) the Provides: line is useless, rpm auto-creates that, should be removed. 2) the BuildRoot: is insufficient for meeting the packaging guidelines. Must include %{name}, %{version} and %{release} in the BuildRoot value to meet the guidelines. 3) the %description is completely missing 4) the %setup line should be just '%setup -q', which does exactly the same thing as what's there now 5) rm -rf $RPM_BUILD_ROOT doesn't belong at the %build stage, it belongs at the start of the %install stage. 6) don't use mkdir in %build stage either, than belongs in %install as well 7) use of %makeinstall is typically forbidden by the packaging guidelines 8) use either %{buildroot} or $RPM_BUILD_ROOT, not both intermixed 9) use %{_sysconfdir} in place of /etc 10) the URL tag is missing 11) the license field should be versioned these days (ex: GPLv2+) 12) AUTHORS, COPYING, NEWS, README, ChangeLog should be installed as %doc 13) the init script doesn't contain either a 'status' or 'reload' option (rpmlint dislikes this) I think that's it for the first pass... :)
Ah, not quite. One more thing. In %preun, the service needs to be stopped before its deleted (or you'll leave its lock file lingering about).
Created attachment 281311 [details] updated modversions srpm This is an updated modversions srpm that remedies the majority of the issues I raised. I believe all that is left to address with this version is the missing URL tag (and if there is one, a full http link to the Source0 tarball).
Thanks for doing this. Saved me doing it on the weekend! As fas as the URL goes, I suggest just redhat.com - if we add that, you ok with the package then? Jon.
Well, typically, the URL points to a project page of some sort, where you can also find download links, docs, etc... Maybe just stash the README, tarball and srpm at http://people.redhat.com/jcm/modversions/ or something like that? Otherwise, yeah, I think everything is pretty much good to go.
Can this bug be closed yet?
Yeah, closing.