Bug 405901 - Review Request: libconfig - C/C++ configuration file library
Review Request: libconfig - C/C++ configuration file library
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jeremy Katz
Fedora Extras Quality Assurance
: 264641 (view as bug list)
Depends On:
  Show dependency treegraph
Reported: 2007-11-30 09:29 EST by Tom "spot" Callaway
Modified: 2007-11-30 17:12 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-11-30 10:56:08 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
katzj: fedora‑review+
tcallawa: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Tom "spot" Callaway 2007-11-30 09:29:45 EST
Spec URL: http://www.auroralinux.org/people/spot/review/new/libconfig.spec
SRPM URL: http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-1.fc9.src.rpm
Libconfig is a simple library for manipulating structured configuration
files. This file format is more compact and more readable than XML. And
unlike XML, it is type-aware, so it is not necessary to do string parsing
in application code.
Comment 1 Jeremy Katz 2007-11-30 09:40:30 EST
Missing a build requires on texinfo-tex for building the PDF docs and I get
unpackaged files (/usr/share/info/dir dropping).

rpmlint is clean, everything else looks pretty good
Comment 2 Tom "spot" Callaway 2007-11-30 10:09:32 EST
New SPEC: http://www.auroralinux.org/people/spot/review/new/libconfig.spec

Had that texinfo-tex as a Requires instead of a BuildRequires. Whoops. :)
Comment 3 Jeremy Katz 2007-11-30 10:13:44 EST
pkgconfig dep should also be in the -devel package, not the main package.  And
looking at the actual docs, they're docs for using the library and so belong
more in the -devel package than the main one and then the appropriate scriptlet
and requires move
Comment 4 Mamoru TASAKA 2007-11-30 10:15:26 EST
*** Bug 264641 has been marked as a duplicate of this bug. ***
Comment 6 Jeremy Katz 2007-11-30 10:32:52 EST
Looks good, rpmlint is still happy.

Comment 7 Tom "spot" Callaway 2007-11-30 10:56:08 EST
CVS done, builds away, thanks for the quick review.
Comment 8 Mamoru TASAKA 2007-11-30 10:58:07 EST
(In reply to comment #5)
> Good points. Fixed.
> New SPEC: http://www.auroralinux.org/people/spot/review/new/libconfig.spec
> New SRPM:
> http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-3.fc9.src.rpm

As expected, this does not build...

Note You need to log in before you can comment on or make changes to this bug.