Spec URL: http://www.auroralinux.org/people/spot/review/new/libconfig.spec SRPM URL: http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-1.fc9.src.rpm Description: Libconfig is a simple library for manipulating structured configuration files. This file format is more compact and more readable than XML. And unlike XML, it is type-aware, so it is not necessary to do string parsing in application code.
Missing a build requires on texinfo-tex for building the PDF docs and I get unpackaged files (/usr/share/info/dir dropping). rpmlint is clean, everything else looks pretty good
New SPEC: http://www.auroralinux.org/people/spot/review/new/libconfig.spec New SRPM: http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-2.fc9.src.rpm Had that texinfo-tex as a Requires instead of a BuildRequires. Whoops. :)
pkgconfig dep should also be in the -devel package, not the main package. And looking at the actual docs, they're docs for using the library and so belong more in the -devel package than the main one and then the appropriate scriptlet and requires move
*** Bug 264641 has been marked as a duplicate of this bug. ***
Good points. Fixed. New SPEC: http://www.auroralinux.org/people/spot/review/new/libconfig.spec New SRPM: http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-3.fc9.src.rpm
Looks good, rpmlint is still happy. APPROVED
CVS done, builds away, thanks for the quick review.
(In reply to comment #5) > Good points. Fixed. > > New SPEC: http://www.auroralinux.org/people/spot/review/new/libconfig.spec > New SRPM: > http://www.auroralinux.org/people/spot/review/new/libconfig-1.2-3.fc9.src.rpm > As expected, this does not build... http://koji.fedoraproject.org/koji/taskinfo?taskID=267299