Spec URL: http://mmahut.fedorapeople.org/reviews/rmap/rmap.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-1.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=269588 Description: Rmap is a package that will allow you to generate images of the earth from a distance or fairly zoomed in.
Taking this for a review.
the SPEC file is cleanly written and sane, package is functional. rpmlint is all quiet. Please replace #make 'CFLAGS=%{optflags}' %{_smp_mflags} make with make %{_smp_mflags}
Spec file and src rpm updated. http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-2.src.rpm
Thanks for a nice package! All the outstanding issues were fixed. APPROVED
New Package CVS Request ======================= Package Name: rmap Short Description:Rmap is a package that is able to generate images of the earth from a distance Owners: mmahut Branches: devel InitialCC: astronomy-sig (fedora-astronomy-list) Cvsextras Commits: yes
cvs done.
Thank you.