Bug 409281 - Review Request: rmap - Rmap is a package that is able to generate images of the earth from a distance
Summary: Review Request: rmap - Rmap is a package that is able to generate images of t...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Lubomir Rintel
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-03 20:21 UTC by Marek Mahut
Modified: 2009-01-07 18:09 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-06 10:23:52 UTC
Type: ---
Embargoed:
lkundrak: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Marek Mahut 2007-12-03 20:21:45 UTC 
Spec URL:  http://mmahut.fedorapeople.org/reviews/rmap/rmap.spec
SRPM URL:  http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-1.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=269588
Description:  Rmap is a package that will allow you to generate
images of the earth from a distance or fairly zoomed in.
Comment 1 Lubomir Kundrak 2007-12-03 20:25:16 UTC 
Taking this for a review.
Comment 2 Lubomir Kundrak 2007-12-03 21:29:37 UTC 
the SPEC file is cleanly written and sane, package is functional.
rpmlint is all quiet.

Please replace

#make 'CFLAGS=%{optflags}' %{_smp_mflags}
make

with

make %{_smp_mflags}
Comment 3 Marek Mahut 2007-12-03 21:55:55 UTC 
Spec file and src rpm updated.


  http://mmahut.fedorapeople.org/reviews/rmap/rmap-1.2-2.src.rpm
Comment 4 Lubomir Kundrak 2007-12-04 07:39:28 UTC 
Thanks for a nice package!
All the outstanding issues were fixed.

APPROVED
Comment 5 Marek Mahut 2007-12-04 07:59:17 UTC 
New Package CVS Request
=======================
Package Name: rmap
Short Description:Rmap is a package that is able to generate images of the earth
from a distance 
Owners: mmahut
Branches: devel
InitialCC: astronomy-sig (fedora-astronomy-list)
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2007-12-04 20:05:52 UTC 
cvs done.
Comment 7 Marek Mahut 2007-12-06 10:23:52 UTC 
Thank you.
Note You need to log in before you can comment on or make changes to this bug.