Bug 409811 - SIZEOF_LONG is not defined
Summary: SIZEOF_LONG is not defined
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: Red Hat Enterprise Linux 4
Classification: Red Hat
Component: net-snmp
Version: 4.6
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
: ---
Assignee: Jan Safranek
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-12-04 08:12 UTC by Atsushi Nakabayashi
Modified: 2008-02-05 07:44 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-04 14:34:07 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
My proposal patch. (12.50 KB, patch)
2007-12-04 08:12 UTC, Atsushi Nakabayashi
no flags Details | Diff

Description Atsushi Nakabayashi 2007-12-04 08:12:42 UTC
Description of problem:
snmplib/asn1.c(net-snmp-5.1.2-11.EL4.11) uses SIZEOF_LONG,
but it is not defined. 
And net-snmp.org(net-snmp-5.1.4 or more) defines SIZEOF_LONG 
in include/net-snmp/net-snmp-config.h

Version-Release number of selected component (if applicable):
net-snmp-5.1.2-11.EL4.11

Comment 1 Atsushi Nakabayashi 2007-12-04 08:12:42 UTC
Created attachment 276661 [details]
My proposal patch.

Comment 2 RHEL Program Management 2007-12-04 13:15:00 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 3 Jan Safranek 2007-12-04 14:34:07 UTC
I do not see any consequence of the bug. You are right, SIZEOF_LONG is not
defined. But it is used only twice:

1) asn1.c:210
If it is not defined, net-snmp checks integers unnecessarily on 32bit system,
burning few cpu cycles. The result is the same as if SIZEOF_LONG would be defined.

2) asn1.c:1330
Again, if it is not defined, net-snmp checks subidentifier on all architectures,
which is not effective on 32bit system, but has no influence on the result.

Feel free correct me and reopen the bug if I am wrong and you can see some
problems in production. Or contact your Red Hat Support at redhat.com/support,
which is always better than direct Bugzilla report.



Note You need to log in before you can comment on or make changes to this bug.