Red Hat Bugzilla – Bug 41490
builtin ripper blocks on device open after first mp3 encode completes
Last modified: 2008-05-01 11:38:00 EDT
Description of Problem:
The built-in ripper (cdparanoia library) blocks on device open after the
first mp3 encode completes. This is because the file descriptor for the
device is being inherited by the (2nd and later) child (encoder) process
which is forked off while a rip is going on. Patch is to close all fds >
2 (stderr) after fork but before exec (in my patch, this is done in
RedirectIO() in grip.c).
This problem persists into version 2.95. My original patches were created
for this version. Program author has been informed of bug and of patches.
Created attachment 19110 [details]
patch to close fds before exec
Created attachment 19111 [details]
write debug out to stderr, unbuffer stdout so debugging is useful
Created attachment 19112 [details]
updated spec file including my patches
Created attachment 19113 [details]
a source RPM for 2.95 with my patches + the makefile patch
I applied your patches for closing the fd, and for debugging. The new package
(with credit towards you) should show up in rawhide shortly.