Spec URL: http://fedora.lowlatency.de/review/python-httplib2.spec SRPM URL: http://fedora.lowlatency.de/review/python-httplib2-0.4.0-1.fc9.src.rpm Description: A comprehensive HTTP client library that supports many features left out of other HTTP libraries.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 022006c6c5fb75ea082b97d0fcc89d94 httplib2-0.4.0.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + BuildRequires are proper. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available. + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED. SHOULD: make Source URL as http://httplib2.googlecode.com/files/%{name}-%{version}tar.gz
Thanks for the review. New Package CVS Request ======================= Package Name: python-httplib2 Short Description: A comprehensive HTTP client library Owners: awjb Branches: F-7 F-8 Cvsextras Commits: yes
cvs done.
Thanks for the review.
I would like to see and EL-5 branch. I'm happy to maintain if needed.
Package Change Request ====================== Package Name: python-httplib2 New Branches: EL-4 EL-5 Owners: awjb jspaleta