Bug 426912 - Review Request: libopensync-plugin-moto - Plugin for syncing with Motorola phones via libopensync
Review Request: libopensync-plugin-moto - Plugin for syncing with Motorola ph...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-12-28 06:43 EST by Andreas Bierfert
Modified: 2007-12-28 18:45 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-12-28 18:45:46 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Andreas Bierfert 2007-12-28 06:43:06 EST
Spec URL: http://fedora.lowlatency.de/review/libopensync-plugin-moto.spec
SRPM URL: http://fedora.lowlatency.de/review/libopensync-plugin-moto-0.35-1.fc9.src.rpm
Description:
Plugin for syncing with Motorola phones via libopensync
Comment 1 Parag AN(पराग) 2007-12-28 06:58:50 EST
make build failed as =>

--   found opensync-1.0, version 0.22
CMake Error: Error in cmake code at
/builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:10:
INCLUDE Could not find include file: OpenSyncInternal
Current CMake stack:
[1]     /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt
CMake Error: Error in cmake code at
/builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:14:
INSTALL FILES given no DESTINATION!
Current CMake stack:
[1]     /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt
CMake Error: Error in cmake code at
/builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:15:
INSTALL FILES given no DESTINATION!
Current CMake stack:
[1]     /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt
CMake Error: Error in cmake code at
/builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:17:
Unknown CMake command "OPENSYNC_PACKAGE".
-- Configuring done
error: Bad exit status from /var/tmp/rpm-tmp.72977 (%build)


I see that README suggests to install at 
%{_libdir}/opensync and %{_datadir}/opensync but you used
%{_libdir}/opensync-1.0 and %{_datadir}/opensync-1.0 respectively.

also who owns /usr/share/opensync-1.0 and /usr/lib/opensync-1.0 then?


Comment 2 Andreas Bierfert 2007-12-28 07:07:31 EST
You need libopensync{,-devel} >= 0.35 which just finished building in rawhide.
Comment 3 Andreas Bierfert 2007-12-28 07:16:06 EST
http://fedora.lowlatency.de/review/libopensync-plugin-moto.spec
http://fedora.lowlatency.de/review/libopensync-plugin-moto-0.35-1.fc9.src.rpm

Here you go. It now requires libopensync-devel >= 0.35 to be on the save side.

Using opensync-1.0 instead of just opensync is what should be done from now on
so that should be fine. Both dirs are owned by libopensync.
Comment 4 Parag AN(पराग) 2007-12-28 07:41:53 EST
rpmlint reported
libopensync-plugin-moto.i386: E: explicit-lib-dependency libopensync-plugin-python
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

libopensync-plugin-moto.i386: E: no-binary
The package should be of the noarch architecture because it doesn't contain
any binaries.

libopensync-plugin-moto.i386: E: only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
Comment 5 Andreas Bierfert 2007-12-28 07:50:09 EST
Well. The first one is a runtime dependency on the python module and in this
case no explicit-lib-dependency so ok.

The package contains python compiled bytecode so it is not noarch.

Well the rest is nonsense because plugins need to be in the plugins dir.
Comment 6 Parag AN(पराग) 2007-12-28 09:09:54 EST
one last thing before I will do official review.
why cmake used so complex and why not cleanly as given in
http://fedoraproject.org/wiki/Packaging/cmake
Comment 7 Andreas Bierfert 2007-12-28 09:18:23 EST
Ah cool... I was thinking that we need something like that when putting together
the specs. I will change it after import if thats ok with you as I have build
all the other libopensync things already like this. Thanks for bringing it up.
Comment 8 Parag AN(पराग) 2007-12-28 09:40:28 EST
Ok, Hope you will do that after import.

verified upstream source tarball
b81d70466718a08a5dd362dcffc22fe2  libopensync-plugin-moto-0.35.tar.bz2
License is open source compatible and included in package.
rpmlint complains as given in comment #4 but ok as given in comment #5
mock build successful for rawhide
SPEC is clean.

APPROVED.
                 
Comment 9 Andreas Bierfert 2007-12-28 10:29:40 EST
I will no worries. I have already build libopensync with it (see
devel:libopensync-0_35-2_fc9). The rest will follow.

New Package CVS Request
=======================
Package Name: libopensync-plugin-moto
Short Description: Plugin for syncing with Motorola phones via libopensync
Owners: awjb
Branches: F-8
Cvsextras Commits: yes
Comment 10 Kevin Fenzi 2007-12-28 12:57:49 EST
cvs done.
Comment 11 Andreas Bierfert 2007-12-28 18:45:46 EST
Thanks for the review.

Note You need to log in before you can comment on or make changes to this bug.