Spec URL: http://fedora.lowlatency.de/review/libopensync-plugin-moto.spec SRPM URL: http://fedora.lowlatency.de/review/libopensync-plugin-moto-0.35-1.fc9.src.rpm Description: Plugin for syncing with Motorola phones via libopensync
make build failed as => -- found opensync-1.0, version 0.22 CMake Error: Error in cmake code at /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:10: INCLUDE Could not find include file: OpenSyncInternal Current CMake stack: [1] /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt CMake Error: Error in cmake code at /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:14: INSTALL FILES given no DESTINATION! Current CMake stack: [1] /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt CMake Error: Error in cmake code at /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:15: INSTALL FILES given no DESTINATION! Current CMake stack: [1] /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt CMake Error: Error in cmake code at /builddir/build/BUILD/libopensync-plugin-moto-0.35/CMakeLists.txt:17: Unknown CMake command "OPENSYNC_PACKAGE". -- Configuring done error: Bad exit status from /var/tmp/rpm-tmp.72977 (%build) I see that README suggests to install at %{_libdir}/opensync and %{_datadir}/opensync but you used %{_libdir}/opensync-1.0 and %{_datadir}/opensync-1.0 respectively. also who owns /usr/share/opensync-1.0 and /usr/lib/opensync-1.0 then?
You need libopensync{,-devel} >= 0.35 which just finished building in rawhide.
http://fedora.lowlatency.de/review/libopensync-plugin-moto.spec http://fedora.lowlatency.de/review/libopensync-plugin-moto-0.35-1.fc9.src.rpm Here you go. It now requires libopensync-devel >= 0.35 to be on the save side. Using opensync-1.0 instead of just opensync is what should be done from now on so that should be fine. Both dirs are owned by libopensync.
rpmlint reported libopensync-plugin-moto.i386: E: explicit-lib-dependency libopensync-plugin-python You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. libopensync-plugin-moto.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. libopensync-plugin-moto.i386: E: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share.
Well. The first one is a runtime dependency on the python module and in this case no explicit-lib-dependency so ok. The package contains python compiled bytecode so it is not noarch. Well the rest is nonsense because plugins need to be in the plugins dir.
one last thing before I will do official review. why cmake used so complex and why not cleanly as given in http://fedoraproject.org/wiki/Packaging/cmake
Ah cool... I was thinking that we need something like that when putting together the specs. I will change it after import if thats ok with you as I have build all the other libopensync things already like this. Thanks for bringing it up.
Ok, Hope you will do that after import. verified upstream source tarball b81d70466718a08a5dd362dcffc22fe2 libopensync-plugin-moto-0.35.tar.bz2 License is open source compatible and included in package. rpmlint complains as given in comment #4 but ok as given in comment #5 mock build successful for rawhide SPEC is clean. APPROVED.
I will no worries. I have already build libopensync with it (see devel:libopensync-0_35-2_fc9). The rest will follow. New Package CVS Request ======================= Package Name: libopensync-plugin-moto Short Description: Plugin for syncing with Motorola phones via libopensync Owners: awjb Branches: F-8 Cvsextras Commits: yes
cvs done.
Thanks for the review.