Spec URL: http://mmahut.fedorapeople.org/reviews/gcx/gcx.spec SRPM URL: http://mmahut.fedorapeople.org/reviews/gcx/gcx-0.9.11-1.fc8.src.rpm Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=316549 Description: GCX provides a complete set of data-reduction functions for CCD photometry, accessible both from a GUI and the command line. It also controls CCD cameras and telescopes, and implements automatic observation scripting.
1.) Please remove the .svg suffix, it won't build in rawhide with it: gcx.desktop: Icon=/usr/share/gcx/gcx.svg 2.) I'm wondering if you could replace Source2: gcx.svg with the actual URL you got it from. 3.) Does the RPM_OPT_FLAGS="$RPM_OPT_FLAGS" make any sense here? make %{?_smp_mflags} RPM_OPT_FLAGS="$RPM_OPT_FLAGS"
Lubomir, gcx-0.9.11-2.fc8.src.rpm updated. There's no link for gcx.svg, it's taken from debian package.
Thanks Marek. All outstanding problems were adressed. RPMLint is silent now and I can't find any more issues. APPROVED (btw. consider adding a comment stating that the icon is from debian)
New Package CVS Request ======================= Package Name: gcx Short Description: Data-reduction tool for CCD photometry Owners: mmahut Branches: F-8 InitialCC: astronomy-sig Cvsextras Commits: yes
cvs done.
Please make it sure that the directory %{_datadir}/gcx/ is owned by this package.
Mamoru, done. Thank you all!