Bug 427509 - Review Request: hunspell-or - Oriya hunspell dictionaries
Summary: Review Request: hunspell-or - Oriya hunspell dictionaries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-01-04 10:59 UTC by Parag Nemade
Modified: 2008-01-07 07:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-01-07 07:14:37 UTC
Type: ---
Embargoed:
j: fedora-review+
petersen: fedora-cvs+


Attachments (Terms of Use)

Description Parag Nemade 2008-01-04 10:59:28 UTC
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-or.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-or-20050726-1.fc8.src.rpm
Description: Oriya hunspell dictionaries

Comment 1 Parag Nemade 2008-01-06 04:41:36 UTC
Updated links with adding Copyright file
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-or.spec
SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-or-20050726-2.fc8.src.rpm

Comment 2 Jason Tibbitts 2008-01-07 02:34:26 UTC
Looks good to me.

* source files match upstream:
   079e450c3920d3a94c83b08fd90eb7b365a4fbb87b4ece1935f414a02a442502  
   or-demo.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper (none)
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   hunspell-or = 20050726-2.fc9
  =
   hunspell
* %check is not present; not test suite upstream.  I have not tested this
   package as I do not speak Oriya.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED

Comment 3 Parag Nemade 2008-01-07 03:36:56 UTC
Thanks tibbs for review.

New Package CVS Request
=======================
Package Name: hunspell-or
Short Description: Oriya hunspell dictionaries
Owners: pnemade
Branches: F-8
InitialCC: 
Cvsextras Commits: yes



Comment 4 Jens Petersen 2008-01-07 05:33:48 UTC
cvs admin done

Comment 5 Parag Nemade 2008-01-07 07:14:37 UTC
Built for devel and F-8 successfully.
Thanks to tibbs and Jens.


Note You need to log in before you can comment on or make changes to this bug.