Bug 427651 - fix build on sparc for hdf5
Summary: fix build on sparc for hdf5
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: hdf5
Version: rawhide
Hardware: sparc
OS: Linux
low
low
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-01-06 07:45 UTC by Balint Cristian
Modified: 2008-01-07 21:14 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2008-01-07 21:14:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
trivial patch to return proper signal from H5detect on some arches (1.56 KB, patch)
2008-01-06 07:45 UTC, Balint Cristian
no flags Details | Diff
fix fortran compile for sparc. (573 bytes, patch)
2008-01-06 07:47 UTC, Balint Cristian
no flags Details | Diff

Description Balint Cristian 2008-01-06 07:45:32 UTC
Description of problem:
On fedora sparc build fail.

Version-Release number of selected component (if applicable):
hdf5-1.6.6-3

How reproducible:
on a sparc machine with fedora port:
rpmbuild -bb hdf5.spec --target=sparc

  
Actual results:
1) total crash of H5detect fortran autocionfig helper routine.
2) incorect type declaration specific for sparc lead to compile errors.

Expected results:
1) build smooth.
2) pass all tests.

Additional info:

Attacehd 2 patches.

First one patch:
 It fix proper SEGV signal return in case of bus-error or seg-fault. That mean
that fortran part is on his own autodetect for H5detect failed, but it must bail
out with 0 error result during compile time, and no header template is generated.
 This patch should fix any other arch wich cannot relay on H5detect tool during
compile time, so i think it would be smart to drag it in.

Second one patch:
It declare some proper custom types for sparc specific so fortran compilation
should go smooth.

Comment 1 Balint Cristian 2008-01-06 07:45:32 UTC
Created attachment 290902 [details]
trivial patch to return proper signal from H5detect on some arches

Comment 2 Balint Cristian 2008-01-06 07:47:45 UTC
Created attachment 290903 [details]
fix fortran compile for sparc.

Package compile and package self tests went smooth on my u10 sparc box ;-)

Comment 3 Balint Cristian 2008-01-06 07:53:10 UTC
Orion, you might want to file booth for of hdf/hdf5 ones upstream ?
Or let me please know if you want to do it for you, that will be no problem.

~cristian

Comment 4 Balint Cristian 2008-01-06 07:59:10 UTC
BTW, first one patch make sense for rpmbuild wich is pick if a tool/script
return bad signal to rpmbuild, whole rpmbuild bail out. i think upstream folks
like to do evrything manualy so they dont care of signal return, or something
ike that could be my explanation of this lattent bug.

Comment 5 Balint Cristian 2008-01-06 07:59:35 UTC
s/pick/pikky/

Comment 6 Orion Poplawski 2008-01-07 21:14:23 UTC
Thanks for the patches.  Applied in hdf5-1.6.6-4.fc9.


Note You need to log in before you can comment on or make changes to this bug.