Red Hat Bugzilla – Bug 429760
Review Request: dbus-qt3 - Qt3 DBus Bindings
Last modified: 2008-01-28 10:57:58 EST
Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/dbus-qt3/dbus-qt3.spec
SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/dbus-qt3/dbus-qt3-0.8-1.src.rpm
This library provides Qt3-classes for accessing the DBus.
No, not a dup of existing dbus-qt, these are new incompatible qt3 bindings backported from the qt4-based ones. This is needed for some new(er) packages, including knetworkmanager >= 0.7
Upstream tarball is named libdbus-1-qt3, so that's something to consider as a pkg name, I'm not married to using dbus-qt3.
This release is from October 30, the OpenSUSE folks apply a patch to update
this to the latest from KDE SVN to their package, I think we want that patch.
(It's probably what's needed to get knetworkmanager actually buildind.)
dbus-qt3.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 8)
dbus-qt3-devel.x86_64: W: no-documentation
builds fine in mock
sha1sum libdbus-1-qt3-0.8.tar.gz ../SOURCES/libdbus-1-qt3-0.8.tar.gz 8.tar.gz
source matches upstream
Re: comment #1, Kevin, I tried with and without the suse patches, and it didn't
seem to make a difference (ie, it failed exactly the same way).
Dennis, were there any (other) issues as part of this review?
Rex I did not see any other issues.
Then can you please set it to approved?
There were some issues while minor have not been addressed
Well, let's address the issues then. ;-)
> dbus-qt3.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 8)
Since when has this been a blocker?!
> dbus-qt3-devel.x86_64: W: no-documentation
If there's no documentation to ship, then what are you expecting Rex to do
about this? The only documentation which is sort-of required is COPYING (and
even that is a SHOULD item), and that's already shipped in the main package,
along with README, AUTHORS and ChangeLog.
I would like to see the COPYING file in devel and while the mixed tabs spaces
is not critical its nice to have fixed. So i would like it fixed.
I'll fix these np, but I'm curious to why you want COPYING in -devel (too?),
in addition or instead of in the main pkg?
Spec URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/dbus-qt3/dbus-
SRPM URL: http://kdeforge.unl.edu/apt/kde-redhat/SOURCES/dbus-qt3/dbus-
* Sun Jan 27 2008 Rex Dieter <firstname.lastname@example.org> 0.8-2
- Provides: libdbus-1-qt3(-devel)
- fix mixed tabs/spaces
- -devel: %%doc COPYING
hrm, looks like my urls got truncated, let's try again:
Looks good now.
New Package CVS Request
Package Name: dbus-qt3
Short Description: Qt3 DBus Bindings
Branches: F-7 F-8
Cvsextras Commits: yes
(anyone interested in comaintaining, great, feel free to add yourself throug
importing, and building now.