Red Hat Bugzilla – Bug 430249
neofb: avoid overwriting fb_info fields
Last modified: 2009-03-10 17:44:49 EDT
Description of problem:
Marcio Buss has reported a multiple possible buffer overflows in the
Linux kernel Neofb video driver.
On file drivers/video/neofb.c it seems there are multiple buffer overrrun
errors involving "info->fix.id" For example, on line 2103 the statement
sprintf(info->fix.id, "MagicGraph 256XL+");
writes 18 bytes (including the terminator character) into info->fix.id,
yet fix.id is only 16 bytes long. Is there any catch here, or the programmer
did overlook the lenght of "id"?
Comment from Andrew Morton:
"I queued neofb-avoid-overwriting-fb_info-fields.patch to address this."
Upstream URL of this problem:
Patch provided (and mentioned by Andrew Morton):
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link(s) below. You may reopen this bug report
if the solution does not work for you.