Bug 430249 - neofb: avoid overwriting fb_info fields
neofb: avoid overwriting fb_info fields
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
low Severity low
: ---
: ---
Assigned To: Red Hat Product Security
: Security
Depends On: 430250 430251 430252 430253 430254
  Show dependency treegraph
Reported: 2008-01-25 10:51 EST by Jan Lieskovsky
Modified: 2009-03-10 17:44 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-03-10 17:44:49 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Jan Lieskovsky 2008-01-25 10:51:17 EST
Description of problem:

Marcio Buss has reported a multiple possible buffer overflows in the
Linux kernel Neofb video driver. 


On file drivers/video/neofb.c it seems there are multiple buffer overrrun
errors involving "info->fix.id" For example, on line 2103 the statement

sprintf(info->fix.id, "MagicGraph 256XL+");

writes 18 bytes (including the terminator character) into info->fix.id,
yet fix.id is only 16 bytes long. Is there any catch here, or the programmer
did overlook the lenght of "id"?


Comment from Andrew Morton:

"I queued neofb-avoid-overwriting-fb_info-fields.patch to address this."

Upstream URL of this problem:


Patch provided (and mentioned by Andrew Morton): 

Comment 3 Vincent Danen 2009-03-10 17:44:49 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link(s) below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.