Bug 430859 - Review Request: netmonitor - The free linux network bandwidth monitor
Review Request: netmonitor - The free linux network bandwidth monitor
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
low Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-01-30 05:03 EST by Krzysztof Kurzawski
Modified: 2008-01-31 17:04 EST (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-01-31 17:04:09 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Krzysztof Kurzawski 2008-01-30 05:03:35 EST
Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-1.fc8.src.rpm
Description: Netmon is a simple program for monitoring bandwidth and data 
usage on linux machines. It is useful for those with a broadband connections 
that pay for their data or have download limits.
Comment 1 manuel wolfshant 2008-01-30 05:23:41 EST
The place of the "./configure" line is in %build, not in %prep, and unless there
is a very good reason to not do it, it should probably be replaced with
"%configure <any needed parameters>"
Comment 2 Parag AN(पराग) 2008-01-30 05:34:35 EST
Suggestions:-
   Apply following patch which resolves
1) compiler flags not honored issue
2) remove unneeded "make install" call
3) remove unnecessary INSTALL file 

==============================================================================
 %prep
-%setup -q -n %{name}-0.4b
-./configure --libdir=%{_libdir}
+%setup -q -n %{name}-0.4b

 %build
-#nothing to build
+./configure --libdir=%{_libdir} --prefix=%{_prefix}
+%{__make} CFLAGS="$RPM_OPT_FLAGS" %{?_smp_mflags}

 %install
 rm -rf $RPM_BUILD_ROOT
 mkdir -p $RPM_BUILD_ROOT%{_bindir}
 mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
-make install DESTDIR=%{buildroot}
-cp -p src/%{name} $RPM_BUILD_ROOT%{_bindir}
-cp -p src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1
+install -p -m755 src/%{name} $RPM_BUILD_ROOT%{_bindir}
+install -p -m644 src/%{name}.1 $RPM_BUILD_ROOT%{_mandir}/man1

 %clean
 rm -rf $RPM_BUILD_ROOT

 %files
 %defattr(-,root,root,-)
-%doc README INSTALL TODO COPYING NEWS AUTHORS ChangeLog
-%exclude /usr/local/bin/%{name}
-%exclude /usr/local/man/man1/%{name}.1
+%doc README TODO COPYING NEWS AUTHORS ChangeLog
 %{_mandir}/man1/%{name}.1.gz
 %{_bindir}/%{name}

=============================================================================

When I tried to create patch I got some encoding issue to include pl language
description to be included in patch so pasting here directly.
Comment 3 Parag AN(पराग) 2008-01-30 05:35:24 EST
oh yes. Change ./configure  to %configure in above patch
Comment 4 Krzysztof Kurzawski 2008-01-30 05:46:44 EST
Fixed.
Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-1.fc8.src.rpm

Thanks for review!
Comment 6 Parag AN(पराग) 2008-01-30 06:39:33 EST
Nice. You got better SPEC than what I suggested based on your initial SPEC.
But I see that your SPEC in SRPM still contains INSTALL file
Also, I confused on bloc word in changelog. You can use section word instead of
that.
 
Comment 8 Terje Røsten 2008-01-30 15:29:38 EST
Some pedantic issue:

You are using $RPM_BUILD_ROOT and %{buildroot}:

rm -rf $RPM_BUILD_ROOT
make install DESTDIR=%{buildroot}

it's the same thing, use pick one and use that.

There are no make step %build, it that correct?


Comment 9 Krzysztof Kurzawski 2008-01-30 16:06:42 EST
Fixed.
Spec URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor.spec
SRPM URL: http://kurzawa.nonlogic.org/rpm/netmonitor/netmonitor-0.5-4.fc8.src.rpm

I think here is nothing to build.
Comment 10 Parag AN(पराग) 2008-01-30 23:36:29 EST
README clearly suggests that 
To compile netmon type the following command
./configure
./make
./make install


Add make command to build section
make %{?_smp_mflags}
Comment 12 Parag AN(पराग) 2008-01-31 05:07:40 EST
Review:
+ package builds in mock (rawhide i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream.
fefca04be4b7272955fe5a5c93232842  netmonitor-0.5.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ Compiler flags used correctly.
+ defattr usage is correct
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ no translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI app.

APPROVED.
Comment 13 Krzysztof Kurzawski 2008-01-31 05:26:06 EST
New Package CVS Request
=======================
Package Name: netmonitor
Short Description: The free linux network bandwidth monitor
Owners: kurzawa
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes
Comment 14 Terje Røsten 2008-01-31 05:57:25 EST
More pedantic things:

if you change make install line to

make install DESTDIR=$RPM_BUILD_ROOT INSTALL="%{__install} -p"

the timestamps will be preserved (which is good thing).

Comment 16 Kevin Fenzi 2008-01-31 13:11:01 EST
cvs done.
Comment 17 Krzysztof Kurzawski 2008-01-31 17:04:09 EST
Imported and built. Thanks again for review!

Note You need to log in before you can comment on or make changes to this bug.