Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-1.fc8.src.rpm Description: Xhotkeys provides a simple and easily configurable hotkey launcher for the X-Window System, binding keys and mouse buttons to configurable commands. It should work on all desktops (Gnome, KDE, Xfce, ...) available for the GNU/Linux operating system. Configuration files can be modified manually or using a graphical GTK+ configurator.
- Correct install section - Correct files section Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-2.fc8.src.rpm
koji build failed http://koji.fedoraproject.org/koji/taskinfo?taskID=390860 You have missing BR: ImageMagick and also Requires: python-xlib
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-3.fc8.src.rpm Thanks for review!
Created attachment 293793 [details] some spec fixes
Created attachment 293794 [details] Fix install locations in Makefile This will fix install locations as well as preserve timestamps
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-4.fc8.src.rpm
When installed its not working because first time we try to use it try to find .xhotkeys under your $HOME. I think you better remove SOURCE1 and provide upstream desktop only.
I think modifying SOURCE1 desktop file to include --config is enough
Sorry, but could you repeat what have I to do?
your SOURCE1 file should look like this [Desktop Entry] Encoding=UTF-8 Name=Xhotkeys GenericName=Xhotkeys Comment=Hotkeys for the X-Window Exec=xhotkeys --config Icon=xhotkeys Terminal=false Type=Application Categories=Utility; GenericName[pl_PL]=Xhotkeys Note:- I suggest adding --config in Exec line
Fixed Spec URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys.spec SRPM URL: http://kurzawa.nonlogic.org/rpm/xhotkeys/xhotkeys-0.9.8.3-5.fc8.src.rpm
Review: + package builds in mock (rawhide i386). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=394380 + rpmlint is silent for SRPM and for RPM. + source files match upstream. 6544b487e23ab1290078cff0f2e96a6f xhotkeys_0.9.8.3.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc files present. + BuildRequires are proper. + Compiler flags are honoured correctly. + defattr usage is correct. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code. + no static libraries. + no .pc file present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + gtk-update-icon-cache scriptlets are used. + Desktop file installed correctly + GUI app. APPROVED.
New Package CVS Request ======================= Package Name: xhotkeys Short Description: Hotkeys for the X-Window Owners: kurzawa Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Imported and built. Thanks again for review!