Bug 433571 - Review Request: php-pear-Structures-DataGrid-Renderer-CSV - Renders CSV strings/files
Summary: Review Request: php-pear-Structures-DataGrid-Renderer-CSV - Renders CSV strin...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Christopher Stone
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-20 01:16 UTC by Brad Walker
Modified: 2008-03-26 21:15 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-03-26 21:15:05 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Brad Walker 2008-02-20 01:16:07 UTC
Spec URL: http://rpm.bradmwalker.com/SPECS/php-pear-Structures-DataGrid-Renderer-CSV.spec
SRPM URL: http://rpm.bradmwalker.com/SRPMS/php-pear-Structures-DataGrid-Renderer-CSV-0.1.4-1.fc9.src.rpm
Description: This is a Renderer driver for Structures_DataGrid that generates a CSV string.

A much better interface for generating CSV files than using fputcsv().

Comment 1 Christopher Stone 2008-02-24 22:51:35 UTC
==== REVIEW CHECKLIST ====
- rpmlint output
php-pear-Structures-DataGrid-Renderer-CSV.noarch: W: no-documentation
- package named according to package naming guidelines
- spec filename matches %{name}
- package meets packaging guidelines
- licensed with fedora approved license
- license tag matches actual license
- license not provided in source package
- spec written in American English
- spec file legible
- sources match upstream
69f37de4a299d09babed50d0e8f1caab  Structures_DataGrid_Renderer_CSV-0.1.4.tgz
69f37de4a299d09babed50d0e8f1caab 
../SOURCES/Structures_DataGrid_Renderer_CSV-0.1.4.tgz
- successfully compiles and builds on F-8 x86_64
- All build dependencies listed in BR
- no locales
- no shared libraries
- package is not relocatable
- package requires necessary packages for directories it uses
- no duplicates in %files
- file permissions set properly
- package contains proper %clean section
- macro usage is consistent
- package contains code
- no large documentation
- %doc files do not affect runtime
- no header files
- no static libraries
- no pkgconfig files
- no libraries with suffixes
- no devel subpackage
- no libtool archives
- not a GUI application
- package does not own files or directories owned by other packages
- buildroot properly prepped for %install
- all filenames valid UTF-8

*** APPROVED ***


Note You need to log in before you can comment on or make changes to this bug.