Trying to install a PV guest using an invalid url in virt-install or virt-manager throws doesn't fail cleanly. The error thrown is: Unable to complete install 'exceptions.NameError global name 'FedoraImageStore' is not defined Traceback (most recent call last): File "/usr/share/virt-manager/virtManager/create.py", line 612, in do_install dom = guest.start_install(False, meter = meter) File "/usr/lib/python2.4/site-packages/virtinst/Guest.py", line 811, in start_install self._prepare_install(meter) File "/usr/lib/python2.4/site-packages/virtinst/ParaVirtGuest.py", line 56, in _prepare_install self._installer.prepare(guest = self, meter = meter) File "/usr/lib/python2.4/site-packages/virtinst/DistroManager.py", line 239, in prepare self._prepare_kernel_and_initrd(guest, distro, meter) File "/usr/lib/python2.4/site-packages/virtinst/DistroManager.py", line 209, in _prepare_kernel_and_initrd distro = distro) File "/usr/lib/python2.4/site-packages/virtinst/DistroManager.py", line 115, in acquireKernel scratchdir=scratchdir) File "/usr/lib/python2.4/site-packages/virtinst/DistroManager.py", line 60, in _checkRHDistro store = FedoraImageStore(baseuri, type, scratchdir) NameError: global name 'FedoraImageStore' is not defined This will cause satellite installs to fail as its the piece of code that jumps ahead to try and probe the tree, since the base url doesn't resolve for a satellite hosted tree. See bz 367051.
Created attachment 295539 [details] Update satellite patch to match current internal api
As far as testing this, prior to the fix entering any wrong url for a pv install (ex. http:/iprobablydontexist.com/tree) will throw the above error. After the patch, there will be an error saying roughly "Couldn't access url <blah>".
This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release.
This is a regression from 5.1 so we MUST fix.
This has been committed and built: $ brew latest-pkg dist-5E-qu-candidate python-virtinst Build Tag Built by ---------------------------------------- -------------------- ---------------- python-virtinst-0.300.2-5.el5 dist-5E-qu-candidate crobinso
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHEA-2008-0371.html