Bug 434557 - Review Request: perl-Log-Trivial - Very simple tool for writing very simple log files
Summary: Review Request: perl-Log-Trivial - Very simple tool for writing very simple l...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Patrice Dumas
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-22 18:23 UTC by Orion Poplawski
Modified: 2008-02-26 18:21 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-26 18:21:18 UTC
Type: ---
Embargoed:
pertusus: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Orion Poplawski 2008-02-22 18:23:23 UTC
Spec URL: http://www.cora.nwra.com/~orion/fedora/perl-Log-Trivial.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/perl-Log-Trivial-0.31-1.fc8.src.rpm

Description:
Use this module when you want use "Yet Another" very simple, light weight
log file writer.

Comment 1 Patrice Dumas 2008-02-22 23:56:25 UTC
* rpmlint is silent
* free software, license file not included
* follow packaging guidelines
* match upstream
8618cf5e6ffb68d0056b9c9cfc8c56e8  Log-Trivial-0.31.tar.gz
* sane provides
Provides: perl(Log::Trivial) = 0.31

I don't think the signing issue can be solved without upstream
using a known key.

Some BuildRequires are missing from fedora, it would be better
to have them, but I won't make it a blocker.


I suggest using
rm debug*.list
to notice when something changes.


APPROVED

Comment 2 Orion Poplawski 2008-02-25 23:04:42 UTC
Thanks for the review.  Changed the rm.

New Package CVS Request
=======================
Package Name: perl-Log-Trivial
Short Description: Very simple tool for writing very simple log files
Owners: orion
Branches: F-8 F-7 EL-5 EL-4
InitialCC: 
Cvsextras Commits: Yes

Comment 3 Kevin Fenzi 2008-02-26 00:05:11 UTC
cvs done.

Comment 4 Orion Poplawski 2008-02-26 18:21:18 UTC
Checked in and built.


Note You need to log in before you can comment on or make changes to this bug.