Bug 434815 - Add -DKDE_DISTRIBUTION_TEXT="Fedora packages" to %{cmake_kde4} in /etc/rpm/macros.kde4
Summary: Add -DKDE_DISTRIBUTION_TEXT="Fedora packages" to %{cmake_kde4} in /etc/rpm/ma...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdelibs
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Lukáš Tinkl
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-02-25 17:11 UTC by Laurent Rineau
Modified: 2015-07-13 17:35 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-02-27 14:26:06 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Laurent Rineau 2008-02-25 17:11:07 UTC
Dear KDE SIG,

  In the CMake cache variable for KDE4 (in kdelibs at least), there exists a 
cache variable named "KDE_DISTRIBUTION_TEXT" with default value "compiled 
source". That string is used by the KBugReport dialogs (see file 
kdeui/dialogs/kbugreport.cpp in kdelibs-4.0.1, line 213). It should be better, 
in Fedora packages, to set it to "Fedora packages", or perhaps maybe "Fedora 
package %{name}-%{version}-%{release}". I propose that change to be applied 
to %{cmake_kde4} in /etc/rpm/macro.kde4, so that all rebuild will have that 
change:
  -DKDE_DISTRIBUTION_TEXT="Fedora package %{name}-%{version}-%{release}"

(I have not tested my proposal.)

Debian packages use "Debian packages", and Ubuntu packages strangely 
use "Kubuntu packages". See for example 
http://archive.ubuntu.com/ubuntu/pool/universe/k/kde4libs/kde4libs_4.0.1-0ubuntu1.diff.gz

Comment 1 Kevin Kofler 2008-02-25 21:55:10 UTC
Ubuntu packages using "Kubuntu packages" is not strange, Kubuntu is just 
Ubuntu's KDE spin, they use the same repositories, so the packages you're 
seeing at archive.ubuntu.com are maintained by the Kubuntu team and are the 
ones which end up in Kubuntu releases.

But yes, setting KDE_DISTRIBUTION_TEXT sounds like a good idea to me.

Comment 2 Lukáš Tinkl 2008-02-27 14:26:06 UTC
Will be in builds >= 4.0.1-8


Note You need to log in before you can comment on or make changes to this bug.