Bug 435576 - Review Request: ncdu - Text-based disk usage viewer
Summary: Review Request: ncdu - Text-based disk usage viewer
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Michael Schwendt
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-02 00:32 UTC by Richard Fearn
Modified: 2009-07-26 19:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-05-03 14:30:34 UTC
Type: ---
Embargoed:
bugs.michael: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)
spec patch (904 bytes, patch)
2008-04-13 08:58 UTC, Michael Schwendt
no flags Details | Diff

Description Richard Fearn 2008-03-02 00:32:23 UTC
Spec URL: http://richardfearn.co.uk/files/fedora/ncdu-1.3-1/ncdu.spec
SRPM URL: http://richardfearn.co.uk/files/fedora/ncdu-1.3-1/ncdu-1.3-1.fc8.src.rpm
Description:

Hello! I'm looking for a sponsor for my first Fedora package, ncdu.

ncdu (Ncurses disk usage) is an ncurses version of the du command. It provides a fast and easy interface to your harddrive.

The SRPM builds using mock against Fedora 8 and devel. The resulting RPMs are rpmlint clean.

Comment 1 Michael Schwendt 2008-04-13 08:58:38 UTC
Created attachment 302260 [details]
spec patch

> Requires:	  ncurses

Delete this. We rely on the automatic library SONAME
dependencies which are added by rpmbuild.
See "rpm --query --requires ..." of the binary rpm.

> ./configure --prefix=%{_usr} --libdir=%{_libdir}

Prefer the %configure macro, as it sets --prefix --libdir
and other values. It also exports our global compiler flags
(which are not built with when running ./configure).
See "rpm --eval %configure" for details.

> %doc %{_mandir}/man1/ncdu.1.gz

Files in %_mandir are marked %doc automatically.

> Summary:	  Ncurses disk usage

I recommend a slightly more descriptive and less ambiguous
summary.

Comment 2 Richard Fearn 2008-04-25 21:00:55 UTC
Thanks for your comments on this package, too, Michael - I'll be updating the
package over the weekend.

Comment 3 Richard Fearn 2008-04-25 22:03:39 UTC
I've made a new package available:

Spec URL: http://richardfearn.co.uk/files/fedora/ncdu-1.3-2/ncdu.spec
SRPM URL: http://richardfearn.co.uk/files/fedora/ncdu-1.3-2/ncdu-1.3-2.fc8.src.rpm

This incorporates the suggestions made by Michael in comment 1. It builds
against Fedora 9 using mock. The resulting RPMs are rpmlint clean.

Comment 4 Richard Fearn 2008-04-29 18:59:13 UTC
Changing bug title to reflect new package summary.

Comment 5 Michael Schwendt 2008-05-01 16:33:49 UTC
Package ncdu-1.3-2.fc8.src.rpm from comment 3: APPROVED


Comment 6 Michael Schwendt 2008-05-01 16:35:12 UTC
Richard, feel free to continue with the process in the
Fedora Accounts System: 
http://fedoraproject.org/wiki/PackageMaintainers/Join


Comment 7 Richard Fearn 2008-05-01 19:43:34 UTC
Thank you Michael!

Comment 8 Richard Fearn 2008-05-02 21:20:31 UTC
New Package CVS Request
=======================
Package Name: ncdu
Short Description: Text-based disk usage viewer
Owners: richardfearn
Branches: F-9
InitialCC: 
Cvsextras Commits: yes


Comment 9 Kevin Fenzi 2008-05-02 22:23:09 UTC
cvs done.

Comment 10 Richard Fearn 2009-07-26 18:34:09 UTC
Package Change Request
======================
Package Name: ncdu
New Branches: EL-5
Owners: richardfearn

Comment 11 Kevin Fenzi 2009-07-26 19:48:59 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.