Description of problem: The mkfs.gfs2 man page states: -p LockProtoName LockProtoName is the name of the locking protocol to use. Acceptable locking protocols are lock_dlm or if you are using GFS2 as a local filesystem (1 node only), you can specify the lock_nolock protocol. If this option is not specified, lock_nolock protocol will be assumed. But the default looks to be lock_dlm since mkfs.gfs2 complains about a bad lock table name. [root@marathon-01 ~]# mkfs -t gfs2 -O /dev/gfs2/gfs20 mkfs.gfs2: locktable error: missing colon in the locktable Version-Release number of selected component (if applicable): gfs2-utils-0.1.43-1.el5 How reproducible: 100% Steps to Reproduce: 1. mkfs -t gfs2 -O /dev/gfs2/gfs20 2. 3. Actual results: See above Expected results: The default should be lock_nolock as stated in the man page. Additional info:
Ah, finally found bug 311591. I knew we talked about this before. How about this for an idea. If the -t option is given, default to lock_dlm. If no -t option, default to lock_nolock. Either way, the man page update was missed in 311591.
Adding Abhi, Steve and Dave to the cc list. We talked about the suggestion in comment #1 about "guessing" the correct protocol based on -t. Personally, I liked the idea but I was overridden. IIRC, Dave's concern was that our defaults need to be consistent. And since gfs2 will primarily used for clustering, the default should simply be lock_dlm. Therefore, I think we just need to change the man page to reflect that.
Yup, that's how the conversation went (comment #2). We should do that for the doc and utils
Created attachment 296818 [details] Proposed patch to fix the problem
I haven't heard much feedback regarding my proposed changes, so I'm going to assume it's alright. There's been some more discussion lately about whether to change the defaults again, but it's kind of late to be making code changes. This patch is just updates to the man page. Requesting flags so I can fix the man page for RHEL5.2.
pm-ack.
The man page change was pushed into the cluster git tree, so I'm marking this bug modified.
An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on the solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2008-0350.html