Bug 437145 - Improper open calls open("/dev/null", 3)
Summary: Improper open calls open("/dev/null", 3)
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: mdadm
Version: 9
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Doug Ledford
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-03-12 16:40 UTC by Eric Paris
Modified: 2008-11-19 14:47 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-11-19 14:47:54 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Eric Paris 2008-03-12 16:40:03 UTC
In the function Monitor() inside Monitor.c I see the line:

                open("/dev/null", 3);

But 3 is not a valid open flag.

O_RDONLY == 0
O_WRONLY == 1
O_RDWR   == 2

For code correctness and portability I think it would be best if this was
changed to use O_RDWR rather than the invalid value "3"

Comment 1 Bug Zapper 2008-05-14 05:59:06 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Fedora Update System 2008-06-27 00:07:24 UTC
mdadm-2.6.7-1.fc9 has been submitted as an update for Fedora 9

Comment 3 Fedora Update System 2008-06-28 22:15:36 UTC
mdadm-2.6.7-1.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mdadm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-5804

Comment 4 Fedora Update System 2008-10-30 13:55:12 UTC
mdadm-2.6.7.1-1.fc9 has been submitted as an update for Fedora 9.
http://admin.fedoraproject.org/updates/mdadm-2.6.7.1-1.fc9

Comment 5 Fedora Update System 2008-10-31 10:26:14 UTC
mdadm-2.6.7.1-1.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update mdadm'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-9325

Comment 6 Fedora Update System 2008-11-19 14:47:35 UTC
mdadm-2.6.7.1-1.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.