Bug 437918 (perl-Devel-LexAlias) - Review Request: perl-Devel-LexAlias - Alias lexical variables
Summary: Review Request: perl-Devel-LexAlias - Alias lexical variables
Status: CLOSED NEXTRELEASE
Alias: perl-Devel-LexAlias
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/Devel-Lex...
Whiteboard:
Keywords:
Depends On:
Blocks: 437919
TreeView+ depends on / blocked
 
Reported: 2008-03-18 05:35 UTC by Chris Weyl
Modified: 2008-03-18 20:08 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-03-18 20:08:22 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-03-18 05:35:43 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Devel-LexAlias-0.04-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Devel-LexAlias.spec

Description:
Devel::LexAlias provides the ability to alias a lexical variable in a
subroutines scope to one of your choosing.

Comment 1 Chris Weyl 2008-03-18 05:37:29 UTC
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=520466


Comment 2 Parag AN(पराग) 2008-03-18 06:58:14 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520466
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
7fe986f50b467fa8575a67f0729fbb1d  Devel-LexAlias-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=1, Tests=11,  0 wallclock secs ( 0.03 cusr +  0.00 csys =  0.03 CPU)
+ Package perl-Devel-LexAlias-0.04-1.fc9 =>
  Provides: LexAlias.so perl(Devel::LexAlias) = 0.04
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >=
0:5.005003 perl(Devel::Caller) perl(DynaLoader) rtld(GNU_HASH)

APPROVED.

Comment 3 Chris Weyl 2008-03-18 07:05:15 UTC
New Package CVS Request
=======================
Package Name: perl-Devel-LexAlias
Short Description: Alias lexical variables
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig

Comment 4 Kevin Fenzi 2008-03-18 17:34:56 UTC
cvs done.

Comment 5 Chris Weyl 2008-03-18 20:08:22 UTC
Thanks for the review! :)


Note You need to log in before you can comment on or make changes to this bug.