SRPM URL: http://fedora.biggerontheinside.net/review/perl-Devel-LexAlias-0.04-1.fc8.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Devel-LexAlias.spec Description: Devel::LexAlias provides the ability to alias a lexical variable in a subroutines scope to one of your choosing.
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=520466
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=520466 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7fe986f50b467fa8575a67f0729fbb1d Devel-LexAlias-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=11, 0 wallclock secs ( 0.03 cusr + 0.00 csys = 0.03 CPU) + Package perl-Devel-LexAlias-0.04-1.fc9 => Provides: LexAlias.so perl(Devel::LexAlias) = 0.04 Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >= 0:5.005003 perl(Devel::Caller) perl(DynaLoader) rtld(GNU_HASH) APPROVED.
New Package CVS Request ======================= Package Name: perl-Devel-LexAlias Short Description: Alias lexical variables Owners: cweyl Branches: F-7, F-8, devel InitialCC: perl-sig
cvs done.
Thanks for the review! :)