Bug 438088 - Review Request: perl-Catalyst-Controller-FormBuilder - Catalyst FormBuilder Base Controller
Review Request: perl-Catalyst-Controller-FormBuilder - Catalyst FormBuilder B...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Extras Quality Assurance
http://search.cpan.org/dist/Catalyst-...
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-03-18 18:44 EDT by Chris Weyl
Modified: 2008-03-19 15:41 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-03-19 15:41:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Chris Weyl 2008-03-18 18:44:05 EDT
SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-FormBuilder-0.04-1.fc8.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Controller-FormBuilder.spec

Description:
This base controller merges the functionality of CGI::FormBuilder with
Catalyst and the following templating systems: Template Toolkit, Mason and
HTML::Template. This gives you access to all of FormBuilder's niceties,
such as controllablefield stickiness, multilingual support, and Javascript
generation. For more details, see CGI::FormBuilder or the website at:

    http://www.formbuilder.org
Comment 1 Chris Weyl 2008-03-18 18:45:10 EDT
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=521638
Comment 2 Parag AN(पराग) 2008-03-18 21:45:03 EDT
Review:
+ package builds in mock.
Koji build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=521638 
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
0cd3b3fd61bfdc551cf8c0352853441b  Catalyst-Controller-FormBuilder-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=4, Tests=16,  2 wallclock secs ( 1.52 cusr +  0.15 csys =  1.67 CPU)
+ Package perl-Catalyst-Controller-FormBuilder-0.04-1.fc9 =>
  Provides: perl(Catalyst::Controller::FormBuilder) = 0.04
perl(Catalyst::Controller::FormBuilder::Action)
perl(Catalyst::Controller::FormBuilder::Action::HTML::Template)
perl(Catalyst::Controller::FormBuilder::Action::Mason)
perl(Catalyst::Controller::FormBuilder::Action::TT)
  Requires: perl(CGI::FormBuilder) perl(CGI::FormBuilder::Source::File)
perl(CGI::FormBuilder::Util) perl(Catalyst) perl(Class::Inspector)
perl(File::Spec) perl(NEXT) perl(Scalar::Util) perl(Tie::IxHash) perl(base)
perl(lib) perl(strict) perl(warnings)

APPROVED.
Comment 3 Chris Weyl 2008-03-18 21:51:06 EDT
New Package CVS Request
=======================
Package Name: perl-Catalyst-Controller-FormBuilder
Short Description: Catalyst FormBuilder Base Controller
Owners: cweyl
Branches: F-7, F-8, devel
InitialCC: perl-sig
Comment 4 Kevin Fenzi 2008-03-19 12:14:14 EDT
cvs done.
Comment 5 Chris Weyl 2008-03-19 15:41:27 EDT
Thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.