Spec URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace.spec SRPM URL: http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace-0.07-1.fc9.src.rpm Description: This plugin will enhance the standard Catalyst debug screen by including a stack trace of your appliation up to the point where the error occurred. Each stack frame is displayed along with the package name, line number, file name, and code context surrounding the line number.
panemade pointed out a problem with another of my packages, that's also in this one - it needs to BuildRequire Test::Pod and Test::Pod::Coverage. I've done a pre-review respin to address this. SPEC URL as above, new SRPM is http://homepages.inf.ed.ac.uk/sxw/perl-Catalyst-Plugin-StackTrace- 0.07-2.fc9.src.rpm
Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=534017 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 4bd2dc12f9b6f6bb310c1fe07a8321f1 Catalyst-Plugin-StackTrace-0.07.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 3 tests skipped. Files=9, Tests=24, 2 wallclock secs ( 1.88 cusr + 0.13 csys = 2.01 CPU) +Package perl-Catalyst-Plugin-StackTrace-0.07-2.fc9 => Provides: perl(Catalyst::Plugin::StackTrace) = 0.07 Requires: perl >= 0:5.008001 perl(Devel::StackTrace) perl(HTML::Entities) perl(NEXT) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) SHOULD: 1)Try adding line to enable tests in %check export TEST_POD=1 MUST: 1) Drop redundant BR BuildRequires: perl >= 1:5.8.1 APPROVED.
ping?
New Package CVS Request ======================= Package Name: perl-Catalyst-Plugin-StackTrace Short Description: Display a stack trace on the Catalyst debug screen Owners: sxw Branches: EL-5 F-7 F-8 InitialCC: Cvsextras Commits: yes
cvs done.
Thanks!