once the INFO test in HTS finds any additional boot parameters(bug#441440), the hwcert catalog should highlight these parameters for reviewers. Better to change the "PASSED"(displayed for each INFO test) to some more informative words(e.g. "Boot Parameter"), and to change the green "correct" mark to some other color(e.g. yellow).
The bug depends on #441440.
Created attachment 309109 [details] Fix Patch : 1.Detect if the info test contains the additional boot parameters.If it has,then use the warning icon and little brown text "(Boot Parameters)" to inform that in the package section. 2.Use yellow highlight the additional boot parameter in the result.cgi's result info. 3.Fix bug:Shouldn't blue highlight the string "notebook" in the result.cgi's result info. Pls review. Best Regards! Nicho
1) I think is overkill, there are many highlights that happen in results, it's ok to leave this off. 2) and 3) look ok,however a test server and better yet a test url directly to a view of the code in action would be nice to see.
Created attachment 312316 [details] Patch Improve: High lighting the boot parameter (2) and fix the "notebook" error (3) The test URL is http://bugdev.devel.redhat.com/hwcert-xisun5/results.cgi?cert_id=456121&id=60512 pls review Thanks a lot! Nicho
Looks good to me, seems to work as well :) If you're happy with it, please check it in.
tested and run good