Bug 441634 - Build warnings from gfs2_edit
Build warnings from gfs2_edit
Status: CLOSED UPSTREAM
Product: Fedora
Classification: Fedora
Component: gfs2-utils (Show other bugs)
rawhide
All Linux
low Severity low
: ---
: ---
Assigned To: Robert Peterson
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-09 04:30 EDT by Steve Whitehouse
Modified: 2008-04-16 12:07 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-04-16 12:07:27 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Steve Whitehouse 2008-04-09 04:30:42 EDT
From the rpm build logs:

gcc -Wall -Wformat=2 -O2 -g -I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/config 
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DRELEASE_VERSION=\"DEVEL.1207697850.0\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/include -I/lib/modules/2.6.24.4-64.fc8/build//fs/gfs2/
-I/lib/modules/2.6.24.4-64.fc8/build//include/
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../include
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../libgfs2 -I/usr/include
-c -o gfs2hex.o /builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c: In function
'print_gfs2':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:75: warning:
format not a string literal and no format arguments
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c: In function
'print_it':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:132: warning:
format not a string literal and no format arguments
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:165: warning:
format not a string literal and no format arguments
gcc -Wall -Wformat=2 -O2 -g -I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/config 
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DRELEASE_VERSION=\"DEVEL.1207697850.0\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/include -I/lib/modules/2.6.24.4-64.fc8/build//fs/gfs2/
-I/lib/modules/2.6.24.4-64.fc8/build//include/
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../include
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../libgfs2 -I/usr/include
-c -o savemeta.o /builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c: In function
'get_journal_inode_blocks':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c:681: warning:
'bh' may be used uninitialized in this function
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c: In function
'save_inode_data':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c:594: warning:
'mybh' may be used uninitialized in this function

Please can you fix these warnings.
Comment 1 Steve Whitehouse 2008-04-09 09:13:28 EDT
While you are fixing things, can you also do the following too:

1. Add GPLv2 to top level dir
2. Add LPGL to libgfs2 dir
3. Take a look at:
http://www.novell.com/coolsolutions/feature/11256.html
and add the Description: and Short-Description: tags (don't think we need any
others really) to our init script as per the example in the url.

That sorts out some of the gfs2-utils package review comments.
Comment 2 Steve Whitehouse 2008-04-16 12:07:27 EDT
Fixed in upstream code. Items from comment #1 will be dealt with as part of the
package review process.

Note You need to log in before you can comment on or make changes to this bug.