Bug 441634 - Build warnings from gfs2_edit
Summary: Build warnings from gfs2_edit
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Fedora
Classification: Fedora
Component: gfs2-utils
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Robert Peterson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-09 08:30 UTC by Steve Whitehouse
Modified: 2008-04-16 16:07 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-04-16 16:07:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Steve Whitehouse 2008-04-09 08:30:42 UTC
From the rpm build logs:

gcc -Wall -Wformat=2 -O2 -g -I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/config 
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DRELEASE_VERSION=\"DEVEL.1207697850.0\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/include -I/lib/modules/2.6.24.4-64.fc8/build//fs/gfs2/
-I/lib/modules/2.6.24.4-64.fc8/build//include/
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../include
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../libgfs2 -I/usr/include
-c -o gfs2hex.o /builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c: In function
'print_gfs2':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:75: warning:
format not a string literal and no format arguments
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c: In function
'print_it':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:132: warning:
format not a string literal and no format arguments
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/gfs2hex.c:165: warning:
format not a string literal and no format arguments
gcc -Wall -Wformat=2 -O2 -g -I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/config 
-DDEFAULT_CONFIG_DIR=\"/etc/cluster\" -DDEFAULT_CONFIG_FILE=\"cluster.conf\"
-DRELEASE_VERSION=\"DEVEL.1207697850.0\" -DHELPER_PROGRAM -D_FILE_OFFSET_BITS=64
-I/usr/include -I/lib/modules/2.6.24.4-64.fc8/build//fs/gfs2/
-I/lib/modules/2.6.24.4-64.fc8/build//include/
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../include
-I/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/../libgfs2 -I/usr/include
-c -o savemeta.o /builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c: In function
'get_journal_inode_blocks':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c:681: warning:
'bh' may be used uninitialized in this function
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c: In function
'save_inode_data':
/builddir/build/BUILD/gfs2-0.1.25.2.02.01/gfs2/edit/savemeta.c:594: warning:
'mybh' may be used uninitialized in this function

Please can you fix these warnings.

Comment 1 Steve Whitehouse 2008-04-09 13:13:28 UTC
While you are fixing things, can you also do the following too:

1. Add GPLv2 to top level dir
2. Add LPGL to libgfs2 dir
3. Take a look at:
http://www.novell.com/coolsolutions/feature/11256.html
and add the Description: and Short-Description: tags (don't think we need any
others really) to our init script as per the example in the url.

That sorts out some of the gfs2-utils package review comments.


Comment 2 Steve Whitehouse 2008-04-16 16:07:27 UTC
Fixed in upstream code. Items from comment #1 will be dealt with as part of the
package review process.


Note You need to log in before you can comment on or make changes to this bug.