Red Hat Bugzilla – Bug 442263
Review Request: quicksynergy - GUI for easily configuring Synergy2
Last modified: 2009-01-07 13:10:40 EST
Spec URL: http://tgmweb.at/gadllah/quicksynergy.spec
SRPM URL: http://tgmweb.at/gadllah/quicksynergy-0.7-1.fc8.src.rpm
QuickSynergy is a graphical interface (GUI) for easily configuring Synergy2,
an application that allows the user to share his mouse and keyboard between
two or more computers.
*** Bug 252133 has been marked as a duplicate of this bug. ***
Thanks for the package.
1.) Desktop file needs some love:
$ desktop-file-validate /home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: key "Encoding" in
group "Desktop Entry" is deprecated
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: value
"Network;Application;" for key "Categories" in group "Desktop Entry" contains a
deprecated value "Application"
This is invalid. You should omit the .png suffix.
Hm, there is no entry key that would tell tell much about what's the application
for. How about "Mouse and Keyboard Sharing" or something similar? Check out
GenericName and Comment keys.
The same applies for "Summary:" in the spec file.
2.) /usr/share/pixmaps/qslogo.png should not be executable.
-rwxr-xr-x 1 root root 3897 2008-04-20 21:34 /usr/share/pixmaps/qslogo.png
Use install -m 644 instead of install to copy it.
In other respects the package looks fine. It is legible, sane. Builds fine in
mock, uses required make and compile flags. rpmlint does not complain.
Thanks for the review.
I have fixed the problems, new srpm and spec:
Thanks, seems fine.
New Package CVS Request
Package Name: quicksynergy
Short Description: Share keyboard and mouse between computers
Branches: F-7 F-8 F-9
Cvsextras Commits: yes