Spec URL: http://huzaifas.fedorapeople.org/spec/psiconv.spec SRPM URL: http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-0.fc8.src.rpm Description: A conversion utility for Psion files. Builds: devel: http://koji.fedoraproject.org/koji/taskinfo?taskID=570268 f8: http://koji.fedoraproject.org/koji/taskinfo?taskID=570268
Doing a full review.
Full review done: MUST FIX: --------- -Missing BuildRequires: ImageMagick-devel bc -The man page for psiconv-config should be in -devel -The doc files under /usr/share/psiconv should be moved to %doc of -devel, iow do this after make install: mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc And then add: " %doc _doc/*" to %files of -devel -License should be GPLv2+ not GPLv2 as far as I can see, any particular reason you've used GPLv2?
(In reply to comment #2) > Full review done: > > MUST FIX: > --------- > -Missing BuildRequires: ImageMagick-devel bc done > -The man page for psiconv-config should be in -devel done > -The doc files under /usr/share/psiconv should be moved to %doc of > -devel, iow do this after make install: > mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc > And then add: " %doc _doc/*" to %files of -devel done > -License should be GPLv2+ not GPLv2 as far as I can see, any particular reason > you've used GPLv2? > done SPEC: http://huzaifas.fedorapeople.org/spec/psiconv.spec SRPM: http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-1.fc8.src.rpm
All good now, approved!
New Package CVS Request ======================= Package Name: psiconv Short Description: A conversion utility for Psion files. Owners: huzaifas Branches: F-8, EL-5 InitialCC: huzaifas Cvsextras Commits: yes
(In reply to comment #4) > All good now, approved! > Thanks a lot for your review :)
cvs done.
Closing as this is in the repo now (atleast for rawhide).