Bug 442854 - Review Request: psiconv : A conversion utility for Psion files
Review Request: psiconv : A conversion utility for Psion files
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Hans de Goede
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-04-17 04:35 EDT by Huzaifa S. Sidhpurwala
Modified: 2008-06-01 04:34 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-01 04:34:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
hdegoede: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Comment 1 Hans de Goede 2008-04-17 04:48:59 EDT
Doing a full review.
Comment 2 Hans de Goede 2008-04-17 05:23:19 EDT
Full review done:

MUST FIX:
---------
-Missing BuildRequires: ImageMagick-devel bc
-The man page for psiconv-config should be in -devel
-The doc files under /usr/share/psiconv should be moved to %doc of
 -devel, iow do this after make install:
 mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
 And then add: " %doc _doc/*" to %files of -devel
-License should be GPLv2+ not GPLv2 as far as I can see, any particular reason
 you've used GPLv2?
Comment 3 Huzaifa S. Sidhpurwala 2008-04-17 06:34:34 EDT
(In reply to comment #2)
> Full review done:
> 
> MUST FIX:
> ---------
> -Missing BuildRequires: ImageMagick-devel bc
done
> -The man page for psiconv-config should be in -devel
done
> -The doc files under /usr/share/psiconv should be moved to %doc of
>  -devel, iow do this after make install:
>  mv $RPM_BUILD_ROOT%{_datadir}/%{name} _doc
>  And then add: " %doc _doc/*" to %files of -devel
done
> -License should be GPLv2+ not GPLv2 as far as I can see, any particular reason
>  you've used GPLv2?
> 
done

SPEC: http://huzaifas.fedorapeople.org/spec/psiconv.spec
SRPM: http://huzaifas.fedorapeople.org/srpms/psiconv-0.9.8-1.fc8.src.rpm


Comment 4 Hans de Goede 2008-04-17 07:25:29 EDT
All good now, approved!
Comment 5 Huzaifa S. Sidhpurwala 2008-04-17 07:31:06 EDT
New Package CVS Request
=======================
Package Name: psiconv
Short Description: A conversion utility for Psion files.
Owners: huzaifas
Branches:  F-8, EL-5
InitialCC: huzaifas
Cvsextras Commits: yes
Comment 6 Huzaifa S. Sidhpurwala 2008-04-17 07:31:48 EDT
(In reply to comment #4)
> All good now, approved!
> 

Thanks a lot for your review :)
Comment 7 Kevin Fenzi 2008-04-17 12:56:19 EDT
cvs done.
Comment 8 Hans de Goede 2008-06-01 04:34:55 EDT
Closing as this is in the repo now (atleast for rawhide).

Note You need to log in before you can comment on or make changes to this bug.