Bug 443604 - virt-manager/clicking on about dialog brings up help page
virt-manager/clicking on about dialog brings up help page
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: virt-manager (Show other bugs)
5.2
All Linux
medium Severity medium
: rc
: ---
Assigned To: Daniel Berrange
Virtualization Bugs
:
Depends On:
Blocks: 443628 449772
  Show dependency treegraph
 
Reported: 2008-04-22 10:32 EDT by ritz
Modified: 2010-10-22 20:20 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-20 16:20:28 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
map about button to about dialog instead of help (1.96 KB, patch)
2008-04-22 10:32 EDT, ritz
no flags Details | Diff
map about button to about dialog instead of help (1.89 KB, patch)
2008-04-22 10:53 EDT, ritz
no flags Details | Diff
Fix help to point to 'Contents' and disable button (2.89 KB, application/octet-stream)
2008-09-17 10:27 EDT, Cole Robinson
no flags Details

  None (edit)
Description ritz 2008-04-22 10:32:54 EDT
Description of problem:
 Clicking on about from host details, brings up help pages.

Version-Release number of selected component (if applicable):
virt-manager-0.5.3-7.el5

How reproducible:
always

Steps to Reproduce:
1. start virt-manager
2. connect to Xen with a local connection
3. click on localhost
4. click on Details
5. click on Help->about

  
Actual results:
yelp pops up

Expected results:
about dialog should pop up

Additional info:
patch based on upstream code attached
Comment 1 ritz 2008-04-22 10:32:54 EDT
Created attachment 303315 [details]
map about button to about dialog instead of help
Comment 2 Daniel Berrange 2008-04-22 10:45:29 EDT
THanks, I have applied this patch upstream

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=862cc4d20e09

It is not a show-stopper issue, so no chance of putting it in 5.2, so I'm
re-targetting for 5.3
Comment 3 ritz 2008-04-22 10:53:49 EDT
Created attachment 303319 [details]
map about button to about dialog instead of help

my bad. updated the patch to reflect the diff correctly.
and thanks for the quick response.
Comment 4 Daniel Berrange 2008-04-22 11:26:54 EDT
Actually, the desired behaviour was to show the help - not the about dialog. The
about dialog is only intended for the main window.  So I've done an additional
patch to change the menu entry text to 'Contents' instead of 'About'.

http://hg.et.redhat.com/virt/applications/virt-manager--devel?cs=99a4efef52ec


Now the help docs themselves are a little outdated, but that's a separate bug...
Comment 5 ritz 2008-04-22 12:04:30 EDT
kool thanks, makes sense.
created a new bug wrt documentation.
Comment 6 RHEL Product and Program Management 2008-06-02 16:05:07 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.
Comment 8 Cole Robinson 2008-09-17 10:27:33 EDT
Created attachment 316966 [details]
Fix help to point to 'Contents' and disable button

This combines the above two fixes, but also disables the 'Contents' button because there is no applicable section in the help files. Yes, the help files really need to be updated, but as said previously this is a separate issue, so just disable the button.
Comment 12 errata-xmlrpc 2009-01-20 16:20:28 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2009-0137.html

Note You need to log in before you can comment on or make changes to this bug.