Bug 444765 - virtio_net driver causing hang at shutdown
Summary: virtio_net driver causing hang at shutdown
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 9
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-04-30 14:48 UTC by Mark McLoughlin
Modified: 2008-06-06 07:44 UTC (History)
3 users (show)

Fixed In Version: 2.6.25.4-30.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-06 07:44:28 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
0001-virtio_net-free-transmit-skbs-in-a-timer.patch (2.70 KB, patch)
2008-04-30 14:48 UTC, Mark McLoughlin
no flags Details | Diff

Description Mark McLoughlin 2008-04-30 14:48:13 UTC
Running KVM guests with a virtio nic, I'm seeing a hang at shutdown at
"iptables: Unloading modules:"

Turns out nf_conntrack is blocking because virtio_net has left a TX skb dangling.

See:

  http://lkml.org/lkml/2008/4/30/207

Adding to F9Blocker because shutdown hangs suck and the fix seems fairly safe.

Comment 1 Mark McLoughlin 2008-04-30 14:48:13 UTC
Created attachment 304236 [details]
0001-virtio_net-free-transmit-skbs-in-a-timer.patch

Comment 2 Bug Zapper 2008-05-14 10:26:03 UTC
Changing version to '9' as part of upcoming Fedora 9 GA.
More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 3 Chuck Ebbert 2008-05-17 02:07:41 UTC
Did we get a better fix for this? Upstream didn't really like the proposed one...

Comment 4 Mark McLoughlin 2008-05-19 09:01:59 UTC
(In reply to comment #3)
> Upstream didn't really like the proposed one...

No, upstream wants to add a *host* feature to throttle tx notification
interrupts and have the guest detect when that feature is available. When it
isn't available, the guest will need to poll for tx completion in a timer.

So, upstream is going to merge my patch and later add the throttling feature to
the host and the guest-side code to take advantage of it:

  http://lkml.org/lkml/2008/5/19/26

Comment 5 Chuck Ebbert 2008-05-20 08:35:06 UTC
Patch in 2.6.25.4-29

Comment 6 Fedora Update System 2008-05-22 15:33:03 UTC
kernel-2.6.25.4-30.fc9 has been submitted as an update for Fedora 9

Comment 7 Fedora Update System 2008-05-29 02:51:03 UTC
kernel-2.6.25.4-30.fc9 has been pushed to the Fedora 9 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kernel'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F9/FEDORA-2008-4630

Comment 8 Fedora Update System 2008-06-06 07:44:08 UTC
kernel-2.6.25.4-30.fc9 has been pushed to the Fedora 9 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.