Spec URL: http://jstanley.fedorapeople.org/roadstencil-fonts.spec SRPM URL: http://jstanley.fedorapeople.org/roadstencil-fonts-1.0-1.fc8.src.rpm Description: A rough font influenced by roadwork stencils
rpmlint: roadstencil-fonts.noarch: W: no-documentation - No docs for fonts.
I'd be happy to review this... look for a full review in a bit.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (OFL) OK - License field in spec matches See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: b8d647fb353946263f9de439b8e55bb3 andyfitz_-_roadstencil.otf b8d647fb353946263f9de439b8e55bb3 roadstencil-fonts-1.0/roadstencil.otf OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version Issues: 1. The upstream website tags this as OFL, so I assume thats the license. It would be nice if there was a included license or readme saying that with the font. I'm not sure thats going to be possible with openfontlibrary.org. Not a blocker. 2. Where did you get the tar.gz? The Source0 URL seems like it should be: http://openfontlibrary.org/people/andyfitz/andyfitz_-_roadstencil.otf 3. rpmlint says: roadstencil-fonts.noarch: W: no-documentation Can be ignored. Can you rework things with the Source0 url from item 2?
Fixed, same spec. New SRPM: http://jstanley.fedorapeople.org/roadstencil-fonts-1.0-2.fc8.src.rpm
Looks good, a pretty simple package. ;) This package is APPROVED.
New Package CVS Request ======================= Package Name: roadstencil-fonts Short Description: Roadstencil fonts Owners: jstanley Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes
cvs done.
roadstencil-fonts-1.0-2.fc9 has been submitted as an update for Fedora 9
roadstencil-fonts-1.0-2.fc8 has been submitted as an update for Fedora 8
Package Change Request ====================== Package Name: roadstencil-fonts New Branches: EL-4 EL-5
roadstencil-fonts-1.0-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
roadstencil-fonts-1.0-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.