Spec URL: http://peter.fedorapeople.org/nagios-plugins-check_sip.spec SRPM URL: http://peter.fedorapeople.org/nagios-plugins-check_sip-1.2-1.fc9.src.rpm Description: A Nagios plugin that will test a SIP server/device for availability and response time. Although this package was easy to cook I've got some thoughts: * This package requires nagios-plugins-perl which requires nagios-plugins. Shoul I drop this explicit "Requires: nagios-plugins"? * Original spec-file from Mandriva folks has SysV-scripts in %post and %postun sections (commented out by me). But our nagios-plugins package doesn't have any of these scriptlets - should I drop them completely from this package? See also: http://cvs.fedoraproject.org/viewcvs/rpms/nagios-plugins/
CC'ed Mike McGrath as current nagios-plugins maintainer (sorry for disturbance).
Ver. 1.2-2 %changelog * Sun Aug 10 2008 Peter Lemenkov <lemenkov> 1.2-2 - Fixed issue with multiarch http://peter.fedorapeople.org/nagios-plugins-check_sip.spec http://peter.fedorapeople.org/nagios-plugins-check_sip-1.2-2.fc9.src.rpm
New revision: %changelog * Sat Aug 23 2008 Peter Lemenkov <lemenkov> 1.2-3 - Cleanups http://peter.fedorapeople.org/nagios-plugins-check_sip.spec http://peter.fedorapeople.org/nagios-plugins-check_sip-1.2-3.fc9.src.rpm
New revision: http://peter.fedorapeople.org/nagios-plugins-check_sip.spec http://peter.fedorapeople.org/nagios-plugins-check_sip-1.2-4.fc9.src.rpm %changelog * Tue Sep 30 2008 Peter Lemenkov <lemenkov> 1.2-4 - Fixed project's URL - Removed unnecessary explicit "Provides:"
Will review now. coming ... :-)
APPROVED Suggestions: 1. Fix space and tab mix 2. Include CHANGES also NA = Not applicable, ! = requires attention, x = passed http://koji.fedoraproject.org/koji/taskinfo?taskID=865791 [rpmbuild@rocky SRPMS]$ rpmlint nagios-plugins-check_sip-1.2-4.fc9.src.rpm nagios-plugins-check_sip.src: W: mixed-use-of-spaces-and-tabs (spaces: line 57, tab: line 3) 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Please correct this [rpmbuild@rocky i386]$ rpmlint -i nagios-plugins-check_sip-1.2-4.fc9.i386.rpm nagios-plugins-check_sip.i386: E: no-binary The package should be of the noarch architecture because it doesn't contain any binaries. Fine nagios-plugins-check_sip.i386: E: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. Fine 1 packages and 0 specfiles checked; 2 errors, 0 warnings. Required: [x] package name [x] package base name and spec name [x] packaging guidelines [x] license file included [x] license correct [x] spec legible & in American english [x] md5sum checked source okay [x] package compiled on all primary architectures [x] Buildrequires tag - okay [NA] locale [NA] desktop file - GUI [x] owns all directories it creates [x] permissions in %defattr correct [x] %clean and %install section have 'rm -rf $RPM_BUILD_ROOT' [x] %doc files don't have any dependency on other section of package [x] valid encoding Optional: [x] description and summary fine [NA] license file query [x] package functioning - okay [x] any scripts [x] no dependencies outside FHS guideline paths [!] you may like to include CHANGES file
Thanks! Added CHANGES and fixed small issue with tab/space mix New Package CVS Request ======================= Package Name: nagios-plugins-check_sip Short A Nagios plugin to check SIP servers and devices Owners: peter Branches: EL-4 EL-5 F-8 F-9 InitialCC: peter
cvs done.
nagios-plugins-check_sip-1.2-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
nagios-plugins-check_sip-1.2-5.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report.