Description of Problem: gal/Makefile.am contains | libgal_la_LDFLAGS = -version-info $(GAL_CURRENT):$(GAL_REVISION):$(GAL_AGE) \ | $(ICONV_LIBS) $(GAL_LIBS) where $(GAL_LIBS) gets expanded to | GAL_LIBS = -lgal -rdynamic -L/usr/lib -L/usr/X11R6/lib ... The $(GAL_LIBS) was added by your libgal-borken.patch. When trying to compile gal without an installed gal I get ------------- make ---------------- rm -fr .libs/libgal.la .libs/libgal.* .libs/libgal.* gcc -shared bogus_automake_hack.lo util/e-bit-array.lo [... a lot of other .lo files ...] -lgal -L/usr/lib -L/usr/X11R6/lib -lgnomeprint -ltiff -ljpeg -lpng -lglade-gnome -lglade -lxml -lz -lgnomeui -lart_lgpl -lgdk_imlib -lSM -lICE -lgnome -lgnomesupport -lesd -laudiofile -ldb1 -lgdk_pixbuf -lgtk -lgdk -lgmodule -lglib -ldl -lXi -lXext -lX11 -lm -lgnomecanvaspixbuf -lc -Wl,-soname -Wl,libgal.so.7 -o .libs/libgal.so.7.0.0 /usr/bin/ld: cannot find -lgal collect2: ld returned 1 exit status make[3]: *** [libgal.la] Error 1 make[2]: *** [all-recursive] Error 1 ------------------------------------ and the build fails. Replaced the $(GAL_LIBS) with $(filter-out -lgal, $(GAL_LIBS)) in your patch should solve to problem. How Reproducible: evrytime Steps to Reproduce: 1. rpm -e gal-devel 2. rpm --rebuild gal-0.8-4.src.rpm Actual Results: ... lm -lgnomecanvaspixbuf -lc -Wl,-soname -Wl,libgal.so.7 -o .libs/libgal.so.7.0.0 /usr/bin/ld: cannot find -lgal collect2: ld returned 1 exit status make[3]: *** [libgal.la] Error 1 make[2]: *** [all-recursive] Error 1 make[1]: *** [all-recursive] Error 1
Created attachment 23627 [details] fix for this bug, rerun 'autoconf' to regen. configure
Sorry!!! Patch I submitted is incorrect. If you patch this way, compilation for all programs that use gal, will broke. Correct patch is to fix existing patch, libgal-broken.patch This patch adds $(GAL_LIBS) to libgal_la_LDFLAGS. What is wrong here: $(GAL_LIBS) contain -lgal, which should be filtered out. I fill providing patch for patch is a bit overkill, so I attach fixed libgal-broken.patch. Do not use gal-cyclicdep.patch
Created attachment 23647 [details] fixed version
Alex seems to have fixed this in July: * Tue Jul 24 2001 Alexander Larsson <alexl> - Fix libgal-broken.patch to not link libgal.so to -lgal.