Bug 450484 - Review Request: telepathy-sofiasip - SIP connection manager for Telepathy
Review Request: telepathy-sofiasip - SIP connection manager for Telepathy
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Matěj Cepl
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-08 22:12 EDT by Brian Pepple
Modified: 2008-06-10 20:11 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-10 20:11:29 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mcepl: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)
spec file with fixed TABS (1.28 KB, text/plain)
2008-06-10 10:53 EDT, Matěj Cepl
no flags Details

  None (edit)
Description Brian Pepple 2008-06-08 22:12:19 EDT
Spec URL: http://bpepple.fedorapeople.org/rpms/telepathy-sofiasip.spec
SRPM URL: http://bpepple.fedorapeople.org/rpms/telepathy-sofiasip-0.5.8-1.fc9.src.rpm
Description: telepathy-sofiasip is a SIP connection manager for the Telepathy
framework based on the SofiaSIP-stack.

Note: this package contains 2 header files which would normally go into a devel subpackage, but I decided against that since that's all it would contain.

Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=653004
Comment 1 Matěj Cepl 2008-06-10 10:53:14 EDT
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistent macro usage.
OK - Has dist tag
OK - Meets Packaging Guidelines.
OK - License (LGPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
[matej@viklef redhat]$ md5sum SOURCES/telepathy-sofiasip-0.5.8.tar.gz 
023dceb1d48f34b7a9d5614cfda25907  SOURCES/telepathy-sofiasip-0.5.8.tar.gz
[matej@viklef redhat]$ md5sum ~/telepathy-sofiasip-0.5.8.tar.gz 
023dceb1d48f34b7a9d5614cfda25907  /home/matej/telepathy-sofiasip-0.5.8.tar.gz
[matej@viklef redhat]$ 
See below - BuildRequires correct (build in koji)
Not Sure - Package has %defattr and permissions on files is good.
%{_includedir}/%{name}-0.6/
do we have to have the number written there -- could not it be at least macro
somewhere in the top of the file? Or it won't change?

OK - Package has a correct %clean section.
OK - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
OK - Builds in mock (koji)
OK - Builds on all supported archs

OK - final provides and requires are sane

Rpmlint is not silent!!!
[matej@viklef redhat]$ rpmlint -i RPMS/i386/telepathy-sofiasip-0.5.8-1.fc9.i386.rpm 
telepathy-sofiasip.i386: W: devel-file-in-non-devel-package
/usr/include/telepathy-sofiasip-0.6/tpsip/event-target.h
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

telepathy-sofiasip.i386: W: devel-file-in-non-devel-package
/usr/include/telepathy-sofiasip-0.6/tpsip/sofia-decls.h
A development file (usually source code) is located in a non-devel
package. If you want to include source code in your package, be sure to
create a development package.

[matej@viklef redhat]$ 

Well I know it is intentional -- but I really think making -devel package is not
that big deal, and I am quite sure there will be more devel files coming (they
always come). Are you sure about this?

and (cosmetic)

[matej@viklef redhat]$ rpmlint -i SRPMS/telepathy-sofiasip-0.5.8-1.fc9.src.rpm
telepathy-sofiasip.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab:
line 18)
The specfile mixes use of spaces and tabs for indentation, which is a
cosmetic annoyance.  Use either spaces or tabs for indentation, not both.

[matej@viklef redhat]$ 

Just did :set et | retab | write 
in vim and attaching new .spec file

Conclusion:

I won't reject the review on the missing -devel package, but please consider
once again.
Comment 2 Matěj Cepl 2008-06-10 10:53:48 EDT
Created attachment 308820 [details]
spec file with fixed TABS
Comment 3 Matěj Cepl 2008-06-10 11:11:21 EDT
Persuaded on IRC about missing -devel package being The Right Thing™

APPROVED
Comment 4 Brian Pepple 2008-06-10 11:32:18 EDT
New Package CVS Request
=======================
Package Name: telepathy-sofiasip
Short Description: SIP connection manager for Telepathy
Owners: bpepple
Branches: F-9
InitialCC:
Cvsextras Commits: yes
Comment 5 Kevin Fenzi 2008-06-10 13:09:16 EDT
cvs done.
Comment 6 Brian Pepple 2008-06-10 20:11:29 EDT
Matej, thanks for the reivew!

Note You need to log in before you can comment on or make changes to this bug.