Bug 451006 - programs build with gcc 4.3 based on gsl require -fgnu89-inline
programs build with gcc 4.3 based on gsl require -fgnu89-inline
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: gsl (Show other bugs)
9
All Linux
medium Severity medium
: ---
: ---
Assigned To: Ivana Varekova
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-06-12 07:28 EDT by Matěj Cepl
Modified: 2009-02-27 20:37 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-02-27 20:37:03 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Matěj Cepl 2008-06-12 07:28:55 EDT
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5) Gecko/2008043010 Fedora/3.0-0.60.beta5.fc9 Firefox/3.0b5

Description of problem:
For the further description see discussion on this thread
http://thread.gmane.org/gmane.comp.statistics.pspp.devel/1898/focus=1908

Version-Release number of selected component (if applicable):
gcc-4.3.0-8.i386, gsl-devel-1.10-10.fc9.i386, pspp-0.6.0-2.fc9.i386, gsl-1.10-10.fc9.i386, gcc-c++-4.3.0-8.i386

How reproducible:
Always


Steps to Reproduce:
1.Build the src.rpm

Actual Results:
Build fails unless
CFLAGS="${CFLAGS:-%optflags} -fgnu89-inline"
is added as a parameter of %configure

Expected Results:
Shouldn't fail

Additional info:
Comment 1 Matěj Cepl 2008-06-12 07:50:03 EDT
Package which fails when build is
http://mcepl.fedorapeople.org/rpms/pspp-0.6.0-2.0.tofail.fc9.src.rpm
and with the above shown %configure line it built perfectly in koji
http://koji.fedoraproject.org/koji/taskinfo?taskID=658938
Comment 2 Ivana Varekova 2008-06-18 03:08:42 EDT
Fixed in gsl-1.11-2.fc10.
Comment 5 Milos Jakubicek 2009-02-03 14:40:36 EST
Why the related patch has been removed and replaced by the -fgnu89-inline flag?

Note that this probably solves the problem for building gsl, but definitely not for other packages which link to it -- they fail to build again.

I just wondered why one of my packages (orsa) failed to build [1] in the mass gcc 4.4 rebuild and was in the category "fails-even-with-43" although I was able to build it with gcc 4.3 in the summer.

Please put that patch back and try to move it upstream.

[1] http://sunsite.mff.cuni.cz/rawhide20090126-gcc44/fails-even-with-43/orsa-0.7.0-2.fc10.src.rpm/build.log
Comment 6 Milos Jakubicek 2009-02-27 20:37:03 EST
Taking back, sorry, this was caused by wrong propagation of the HAVE_INLINE macro in orsa. Nevertheless looking into gsl/gsl_inline.h, I think that the "-fgnu89-inline flag" could be removed at all -- this should be now (and it indeed seems to be) completely covered by the INLINE_FUN macro which is either set to "extern inline" (for the old gnu C) or just to "inline" (for c99).

Note You need to log in before you can comment on or make changes to this bug.