Bug 4518 - [PATCH] Pump forgets stuff after first lease renewal.
[PATCH] Pump forgets stuff after first lease renewal.
Status: CLOSED NEXTRELEASE
Product: Red Hat Linux
Classification: Retired
Component: pump (Show other bugs)
6.0
All Linux
medium Severity low
: ---
: ---
Assigned To: Erik Troan
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 1999-08-14 01:29 EDT by dunham
Modified: 2008-05-01 11:37 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 1999-10-28 10:48:05 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description dunham 1999-08-14 01:29:43 EDT
There is a typo in the parseLease function, clearing out
everything but the lease option in pump, rather than
clearing out just the lease option, i.e.

line 885 of pump.c, which reads:

    intf->set &= INTFINFO_HAS_LEASE;

should be:

    intf->set &= ~INTFINFO_HAS_LEASE;

(note the negation.)

To reproduce on a machine that is not currently running
pump, run "pump" to obtain a lease, then run
"pump -s", observe "Domain" and other extra options.
Run "pump -R" to force renewal. Run "pump -s" again and
see that "Domain" has disappeared.
Comment 1 Bill Nottingham 1999-08-14 15:39:59 EDT
Have you tried the errata pump release?
Comment 2 dunham 1999-08-15 00:23:59 EDT
The latest one I had looked at was 0.6.7, apparently 0.7.0 is in the
the updates directory but not on the errate web page.

Either way, the problem is still there in 0.7.0.  I will update the
Debian package to 0.7.0 and add my fix.  In addition to looking into
this problem, you might want to make sure 0.7.0 shows up on the
errata page.
page.
Comment 3 Erik Troan 1999-10-28 10:48:59 EDT
Thanks for the patch!

Note You need to log in before you can comment on or make changes to this bug.