Bug 453061 - CRM #1831514 - virt-manager/ Remove showing incorrect partition size while adding block devices
CRM #1831514 - virt-manager/ Remove showing incorrect partition size while ad...
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: virt-manager (Show other bugs)
All Linux
medium Severity medium
: rc
: ---
Assigned To: Cole Robinson
Virtualization Bugs
Depends On:
Blocks: 449772
  Show dependency treegraph
Reported: 2008-06-26 20:35 EDT by ritz
Modified: 2010-10-22 22:19 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2009-01-20 16:21:04 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
patch - courtesy of Sadique Puthenp (494 bytes, patch)
2008-06-26 20:35 EDT, ritz
no flags Details | Diff
Attempt to show correct sizes for block device. (2.43 KB, application/octet-stream)
2008-09-17 10:21 EDT, Cole Robinson
no flags Details

  None (edit)
Description ritz 2008-06-26 20:35:04 EDT
Description of problem:

This was only fixed in src/virtManager/create.py and also need to be fixed in
src/virtManager/addhardware.py to prevent the wrong size of 2000MB being
reported while adding a block device after the guest was installed.

The bugzilla where this was fixed in create.py is

How reproducible:

Steps to Reproduce:
In RHEL-5.2, after a guest was installed, please follow the below steps.

- Launch virt-manager.
- Right click on the guest -> Select Details -> Select "Hardware" tab -> Select
"Add" -> Select "Storage device" in the "Hardware type" window and click forward
-> Select "Normal Disk Partition" and a Partition using the "Browse" button ->
Select "Virtual disk" from the "Device type" box and click forward

Actual results:
- On this window the size of the virtual disk would be reported wrongly as 2000MB.

Expected results:
It shouldn't report any size.

Additional info:
patch attached. Courtesy of Sadique Puthenp

Affected version of virt-manager:
Comment 1 ritz 2008-06-26 20:35:05 EDT
Created attachment 310404 [details]
patch - courtesy of Sadique Puthenp
Comment 2 Jeremy West 2008-07-14 10:57:29 EDT
IMHO, the above patch changes the wrongly reported size of 2000MB to a "-". 
This is not a good fix.  Having virt-manager display 2000MB is a BUG and it
should be fixed appropriately.

Comment 3 Cole Robinson 2008-07-15 11:38:24 EDT
Similar fix is already upstream, so I'll just pull that down:


Comment #2, I'm not sure I follow. The bug here is that we are displaying the
"create-a-disk-of-this-size" value in the summary section, even if a block
device was selected (which virt-manager cannot directly create). Just blanking
out this value with a '-' to indicate 'not-relevant-here' seems like a
reasonable step.
Comment 4 RHEL Product and Program Management 2008-07-15 11:42:53 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 8 Cole Robinson 2008-09-17 10:21:30 EDT
Created attachment 316965 [details]
Attempt to show correct sizes for block device.
Comment 9 Cole Robinson 2008-09-17 10:24:16 EDT
To test this, in the new VM wizard or Add Hardware wizard, select an existing disk partition to use to install the guest. Move forward to the summary screen, and the size of this partition should be shown. Now back up and enter something like /dev/cdrom as the partition to use (obviously invalid). The summary screen should now show a '-' as the size.

Previously the size listed here would always be whatever was in the 'File Size' spin button in the add hardware wizard, or an unconditional '-' in the create wizard.
Comment 14 errata-xmlrpc 2009-01-20 16:21:04 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.