Bug 453613 - FEAT: md5sum check should have an override for attaching packages
FEAT: md5sum check should have an override for attaching packages
Status: CLOSED CURRENTRELEASE
Product: Red Hat Hardware Certification Program
Classification: Red Hat
Component: Hardware Catalog (Show other bugs)
5
All Linux
low Severity low
: ---
: ---
Assigned To: eric_liu
Yu Shao
http://hardware.redhat.com
:
Depends On:
Blocks: 169367
  Show dependency treegraph
 
Reported: 2008-07-01 11:17 EDT by Rob Landry
Modified: 2008-08-04 13:57 EDT (History)
5 users (show)

See Also:
Fixed In Version: 3.2rh-20080801.1
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-08-04 13:57:01 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
patch of bug 453613 (10.96 KB, patch)
2008-07-06 18:06 EDT, eric_liu
no flags Details | Diff
A New patch under rob's suggestion (5.43 KB, patch)
2008-07-09 06:14 EDT, eric_liu
no flags Details | Diff
A new patch under rob's instruction (7.73 KB, patch)
2008-07-10 19:34 EDT, eric_liu
no flags Details | Diff
The newest patch has been fixed (7.70 KB, patch)
2008-07-15 22:08 EDT, eric_liu
no flags Details | Diff
a patch fix the comment#7 (3.04 KB, patch)
2008-07-21 12:23 EDT, eric_liu
no flags Details | Diff
a patch fix all of above patches including UI clean (9.60 KB, patch)
2008-07-28 03:37 EDT, eric_liu
no flags Details | Diff
CVS to updated patch + additional UI and code cleanup (7.73 KB, patch)
2008-07-29 17:03 EDT, Rob Landry
no flags Details | Diff

  None (edit)
Description Rob Landry 2008-07-01 11:17:56 EDT
Description of problem:

Sometimes people make mistakes and upload packages to the wrong certs; the
md5sum check in those cases blocks uploading the packages to the correct places,
an override option should be provided such that hwcert-edit persons can upload
the package again to the correct location (this is an interim step while we
continue to enhance the attachments features; eg. later we need to support
deprecating packages as part of this)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 4 eric_liu 2008-07-09 06:12:27 EDT
A New Patch  under Rob 's suggestion has been, improve for patching operation:
Please review  :)
Comment 5 eric_liu 2008-07-09 06:14:24 EDT
Created attachment 311359 [details]
A New patch under rob's suggestion
Comment 6 eric_liu 2008-07-10 19:34:47 EDT
Created attachment 311524 [details]
A new patch under rob's instruction

A new patch under rob's instruction, fixed:

1. sub validateMd5sumOverride()  to verify cgi and user permission;
2. A new error page template for validateMd5sumOverride's permission denies;
2.   New Select statement  with "JOIN , ON" for  multi table;
3.  New struction for while @row=fetchrowarray;
4.  Add the all the comments with only one variable $comment;
5 . remove the duplicated code in hwcert.pl;
6. update the select-option to input-checkbox for override on UI
Comment 10 eric_liu 2008-07-15 22:08:26 EDT
Created attachment 311916 [details]
The newest patch has been fixed

Fix the warn sentence on Error page:

"You are not authorized to override the duplicate md5sum check."
Comment 12 XINSUN 2008-07-15 23:11:11 EDT
Deployed on http://bugdev.devel.redhat.com/hwcert-eric1/
If test pass, will check into cvs.

Nicho
Comment 13 eric_liu 2008-07-16 06:28:40 EDT
Patch  has been checked into cvs.    
Thanks, Nicho Sun  :)
Comment 14 Rob Landry 2008-07-16 10:49:35 EDT
The last patch missed the title text change for the user error as well as a
response to the comments of the changes listed in comment #7.
Comment 15 eric_liu 2008-07-21 12:23:32 EDT
Created attachment 312278 [details]
a patch fix the comment#7
Comment 21 eric_liu 2008-07-28 03:37:12 EDT
Created attachment 312754 [details]
a patch fix  all of  above patches including UI clean
Comment 22 eric_liu 2008-07-28 03:37:47 EDT
a patch fix  all of  above patches including UI clean, please review

Comment 23 eric_liu 2008-07-28 04:02:58 EDT
I have already put this patch on bugdev. but the db has been taken down, so
please review the source code on bugdev in dir eric2

I have test this patch on my own pc, it could be work well on db of bz2.18
Comment 25 Rob Landry 2008-07-28 18:24:01 EDT
Unfortunately the db is down again before I could review.  Is there anything
additional to this new patch or is just a combination of the previous patches? 
If it's new, can you highlight what those changes are in comment; if it's a
combination we'll need to review to separate out the portions that are already
in CVS from those that aren't to verify functionality.
Comment 27 Rob Landry 2008-07-29 17:03:04 EDT
Created attachment 312935 [details]
CVS to updated patch + additional UI and code cleanup
Comment 29 Rob Landry 2008-07-30 12:31:52 EDT
committed to cvs
Comment 30 eric_liu 2008-08-01 06:33:26 EDT
tested and run good

Note You need to log in before you can comment on or make changes to this bug.