Description of problem: Sometimes people make mistakes and upload packages to the wrong certs; the md5sum check in those cases blocks uploading the packages to the correct places, an override option should be provided such that hwcert-edit persons can upload the package again to the correct location (this is an interim step while we continue to enhance the attachments features; eg. later we need to support deprecating packages as part of this) Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
A New Patch under Rob 's suggestion has been, improve for patching operation: Please review :)
Created attachment 311359 [details] A New patch under rob's suggestion
Created attachment 311524 [details] A new patch under rob's instruction A new patch under rob's instruction, fixed: 1. sub validateMd5sumOverride() to verify cgi and user permission; 2. A new error page template for validateMd5sumOverride's permission denies; 2. New Select statement with "JOIN , ON" for multi table; 3. New struction for while @row=fetchrowarray; 4. Add the all the comments with only one variable $comment; 5 . remove the duplicated code in hwcert.pl; 6. update the select-option to input-checkbox for override on UI
Created attachment 311916 [details] The newest patch has been fixed Fix the warn sentence on Error page: "You are not authorized to override the duplicate md5sum check."
Deployed on http://bugdev.devel.redhat.com/hwcert-eric1/ If test pass, will check into cvs. Nicho
Patch has been checked into cvs. Thanks, Nicho Sun :)
The last patch missed the title text change for the user error as well as a response to the comments of the changes listed in comment #7.
Created attachment 312278 [details] a patch fix the comment#7
Created attachment 312754 [details] a patch fix all of above patches including UI clean
a patch fix all of above patches including UI clean, please review
I have already put this patch on bugdev. but the db has been taken down, so please review the source code on bugdev in dir eric2 I have test this patch on my own pc, it could be work well on db of bz2.18
Unfortunately the db is down again before I could review. Is there anything additional to this new patch or is just a combination of the previous patches? If it's new, can you highlight what those changes are in comment; if it's a combination we'll need to review to separate out the portions that are already in CVS from those that aren't to verify functionality.
Created attachment 312935 [details] CVS to updated patch + additional UI and code cleanup
committed to cvs
tested and run good