Red Hat Bugzilla – Bug 454134
Review Request: gnome-desktop-sharp - .NET language binding for mono
Last modified: 2008-07-06 19:34:52 EDT
Spec URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp.spec
SRPM URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp-2.20.1-1.fc10.src.rpm
GnomeDesktop is a .NET language binding for assorted
GNOME libraries from the desktop release.
formal review is here, see notes on the end
OK source files match upstream:
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK build root is correct.
BAD license field matches the actual license.
OK license is open source-compatible (LGPLv2+). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in koji (Rawhide/x86_64).
OK debuginfo package looks complete.
OK rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths, correct
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK correct scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK pkgconfig files are in devel subpackage
OK no libtool .la droppings.
OK not a GUI app.
* are you sure about the LGPLv2+ license tag? I was able to find only LGPLv2
references in the sources
* this package should obsolete the standalone gtksourceview2-sharp package
* the NEWS file can be removed from %doc as there is no real content
Correct, it's a LGPLv2.1 with a shortname LGPLv2.
was confusing with a couple of opened files from previous release gnome-sharp.
All issues are fixed now, this PACKAGE is APPROVED.
New Package CVS Request
Package Name: gnome-desktop-sharp
Short Description: .Net language binding for mono
Branches: F-9 EL-5
imported and built on rawhide.
Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do -- thanks!
(In reply to comment #7)
> Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do --
The update of gnome-sharp to 2.20 (which is required for gnome-desktop-sharp to
be added to F-9) caused a huge amount of collateral damage in rawhide
necessitating rebuilding many mono apps such as f-spot, banshee, muine and
others, see the relevant threads on fedora-devel-list:
Some are still not yet rebuilding because the jump to 2.20 affects many packages
across the entire mono stack in unanticipated ways.
I think it's wise to let the dust settle in rawhide before pushing this to F-9,
gnome-do users can wait.