Bug 454134 - Review Request: gnome-desktop-sharp - .NET language binding for mono
Review Request: gnome-desktop-sharp - .NET language binding for mono
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Dan Horák
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-05 05:46 EDT by Xavier Lamien
Modified: 2008-07-06 19:34 EDT (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-07-05 15:52:06 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dan: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Xavier Lamien 2008-07-05 05:46:25 EDT
Spec URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp.spec
SRPM URL: http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp-2.20.1-1.fc10.src.rpm

Description:
GnomeDesktop is a .NET language binding for assorted
GNOME libraries from the desktop release.
Comment 1 Dan Horák 2008-07-05 08:13:38 EDT
formal review is here, see notes on the end

OK	source files match upstream:
	    b99729f7a7265fb1cecf09ced31e009e3ccd66bb  gnome-desktop-sharp-2.20.1.tar.bz2
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
BAD	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
N/A	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in koji (Rawhide/x86_64).
OK	debuginfo package looks complete.
OK	rpmlint is silent.
BAD	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths, correct
scriptlets exist
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	no headers.
OK	pkgconfig files are in devel subpackage
OK	no libtool .la droppings.
OK	not a GUI app.


* are you sure about the LGPLv2+ license tag? I was able to find only LGPLv2
references in the sources
* this package should obsolete the standalone gtksourceview2-sharp package
* the NEWS file can be removed from %doc as there is no real content
Comment 2 Xavier Lamien 2008-07-05 09:39:22 EDT
Correct, it's a LGPLv2.1 with a shortname LGPLv2.
was confusing with a couple of opened files from previous release gnome-sharp.

SPEC: 
http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp.spec
SRPM:
http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp-2.20.1-2.fc10.src.rpm
                                                                               
                             

Comment 3 Dan Horák 2008-07-05 10:12:49 EDT
All issues are fixed now, this PACKAGE is APPROVED.
Comment 4 Xavier Lamien 2008-07-05 10:29:00 EDT
Thanks Dan.

New Package CVS Request
=======================
Package Name: gnome-desktop-sharp
Short Description: .Net language binding for mono
Owners: laxathom
Branches: F-9 EL-5
InitialCC
Comment 5 Kevin Fenzi 2008-07-05 14:11:10 EDT
cvs done.
Comment 6 Xavier Lamien 2008-07-05 15:52:06 EDT
Thanks Kevin.

imported and built on rawhide.
Comment 7 Michel Alexandre Salim 2008-07-06 18:38:51 EDT
Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do -- thanks!
Comment 8 Alex Lancaster 2008-07-06 19:34:52 EDT
(In reply to comment #7)
> Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do --
thanks!

The update of gnome-sharp to 2.20 (which is required for gnome-desktop-sharp to
be added to F-9) caused a huge amount of collateral damage in rawhide
necessitating rebuilding many mono apps such as f-spot, banshee, muine and
others, see the relevant threads on fedora-devel-list:

http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00159.html
http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00170.html

Some are still not yet rebuilding because the jump to 2.20 affects many packages
across the entire mono stack in unanticipated ways.

I think it's wise to let the dust settle in rawhide before pushing this to F-9,
gnome-do users can wait.

Note You need to log in before you can comment on or make changes to this bug.